From 67656991b32075e8b4a99c6409b0a131206c6941 Mon Sep 17 00:00:00 2001 From: Eli White Date: Wed, 14 Mar 2018 14:04:19 -0700 Subject: [PATCH] Move Image PropTypes to a new file Reviewed By: yungsters Differential Revision: D7270058 fbshipit-source-id: 91ad7700b7e89c393c6977bfd82494d2febda4a4 --- Libraries/Image/Image.ios.js | 118 +----------------------------- Libraries/Image/ImageProps.js | 134 ++++++++++++++++++++++++++++++++++ 2 files changed, 136 insertions(+), 116 deletions(-) create mode 100644 Libraries/Image/ImageProps.js diff --git a/Libraries/Image/Image.ios.js b/Libraries/Image/Image.ios.js index 173d78704f6610..c3e9ad5359c166 100644 --- a/Libraries/Image/Image.ios.js +++ b/Libraries/Image/Image.ios.js @@ -11,6 +11,7 @@ 'use strict'; const EdgeInsetsPropType = require('EdgeInsetsPropType'); +const ImageProps = require('ImageProps'); const ImageResizeMode = require('ImageResizeMode'); const ImageSourcePropType = require('ImageSourcePropType'); const ImageStylePropTypes = require('ImageStylePropTypes'); @@ -38,122 +39,7 @@ const ImageViewManager = NativeModules.ImageViewManager; */ const Image = createReactClass({ displayName: 'Image', - propTypes: { - /** - * See https://facebook.github.io/react-native/docs/image.html#style - */ - style: StyleSheetPropType(ImageStylePropTypes), - /** - * The image source (either a remote URL or a local file resource). - * - * See https://facebook.github.io/react-native/docs/image.html#source - */ - source: ImageSourcePropType, - /** - * A static image to display while loading the image source. - * - * See https://facebook.github.io/react-native/docs/image.html#defaultsource - */ - defaultSource: PropTypes.oneOfType([ - PropTypes.shape({ - uri: PropTypes.string, - width: PropTypes.number, - height: PropTypes.number, - scale: PropTypes.number, - }), - PropTypes.number, - ]), - /** - * When true, indicates the image is an accessibility element. - * - * See https://facebook.github.io/react-native/docs/image.html#accessible - */ - accessible: PropTypes.bool, - /** - * The text that's read by the screen reader when the user interacts with - * the image. - * - * See https://facebook.github.io/react-native/docs/image.html#accessibilitylabel - */ - accessibilityLabel: PropTypes.node, - /** - * blurRadius: the blur radius of the blur filter added to the image - * - * See https://facebook.github.io/react-native/docs/image.html#blurradius - */ - blurRadius: PropTypes.number, - /** - * See https://facebook.github.io/react-native/docs/image.html#capinsets - */ - capInsets: EdgeInsetsPropType, - /** - * See https://facebook.github.io/react-native/docs/image.html#resizemethod - */ - resizeMethod: PropTypes.oneOf(['auto', 'resize', 'scale']), - /** - * Determines how to resize the image when the frame doesn't match the raw - * image dimensions. - * - * See https://facebook.github.io/react-native/docs/image.html#resizemode - */ - resizeMode: PropTypes.oneOf([ - 'cover', - 'contain', - 'stretch', - 'repeat', - 'center', - ]), - /** - * A unique identifier for this element to be used in UI Automation - * testing scripts. - * - * See https://facebook.github.io/react-native/docs/image.html#testid - */ - testID: PropTypes.string, - /** - * Invoked on mount and layout changes with - * `{nativeEvent: {layout: {x, y, width, height}}}`. - * - * See https://facebook.github.io/react-native/docs/image.html#onlayout - */ - onLayout: PropTypes.func, - /** - * Invoked on load start. - * - * See https://facebook.github.io/react-native/docs/image.html#onloadstart - */ - onLoadStart: PropTypes.func, - /** - * Invoked on download progress with `{nativeEvent: {loaded, total}}`. - * - * See https://facebook.github.io/react-native/docs/image.html#onprogress - */ - onProgress: PropTypes.func, - /** - * Invoked on load error with `{nativeEvent: {error}}`. - * - * See https://facebook.github.io/react-native/docs/image.html#onerror - */ - onError: PropTypes.func, - /** - * Invoked when a partial load of the image is complete. - * - * See https://facebook.github.io/react-native/docs/image.html#onpartialload - */ - onPartialLoad: PropTypes.func, - /** - * Invoked when load completes successfully. - * - * See https://facebook.github.io/react-native/docs/image.html#onload - */ - onLoad: PropTypes.func, - /** - * Invoked when load either succeeds or fails. - * - * See https://facebook.github.io/react-native/docs/image.html#onloadend - */ - onLoadEnd: PropTypes.func, - }, + propTypes: ImageProps, statics: { resizeMode: ImageResizeMode, diff --git a/Libraries/Image/ImageProps.js b/Libraries/Image/ImageProps.js new file mode 100644 index 00000000000000..eb09ccd8e4ea37 --- /dev/null +++ b/Libraries/Image/ImageProps.js @@ -0,0 +1,134 @@ +/** + * Copyright (c) 2015-present, Facebook, Inc. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * + * @providesModule ImageProps + * @flow + */ + +'use strict'; + +const EdgeInsetsPropType = require('EdgeInsetsPropType'); +const ImageSourcePropType = require('ImageSourcePropType'); +const ImageStylePropTypes = require('ImageStylePropTypes'); +const PropTypes = require('prop-types'); +const StyleSheetPropType = require('StyleSheetPropType'); + +module.exports = { + /** + * See https://facebook.github.io/react-native/docs/image.html#style + */ + style: StyleSheetPropType(ImageStylePropTypes), + /** + * The image source (either a remote URL or a local file resource). + * + * See https://facebook.github.io/react-native/docs/image.html#source + */ + source: ImageSourcePropType, + /** + * A static image to display while loading the image source. + * + * See https://facebook.github.io/react-native/docs/image.html#defaultsource + */ + defaultSource: PropTypes.oneOfType([ + PropTypes.shape({ + uri: PropTypes.string, + width: PropTypes.number, + height: PropTypes.number, + scale: PropTypes.number, + }), + PropTypes.number, + ]), + /** + * When true, indicates the image is an accessibility element. + * + * See https://facebook.github.io/react-native/docs/image.html#accessible + */ + accessible: PropTypes.bool, + /** + * The text that's read by the screen reader when the user interacts with + * the image. + * + * See https://facebook.github.io/react-native/docs/image.html#accessibilitylabel + */ + accessibilityLabel: PropTypes.node, + /** + * blurRadius: the blur radius of the blur filter added to the image + * + * See https://facebook.github.io/react-native/docs/image.html#blurradius + */ + blurRadius: PropTypes.number, + /** + * See https://facebook.github.io/react-native/docs/image.html#capinsets + */ + capInsets: EdgeInsetsPropType, + /** + * See https://facebook.github.io/react-native/docs/image.html#resizemethod + */ + resizeMethod: PropTypes.oneOf(['auto', 'resize', 'scale']), + /** + * Determines how to resize the image when the frame doesn't match the raw + * image dimensions. + * + * See https://facebook.github.io/react-native/docs/image.html#resizemode + */ + resizeMode: PropTypes.oneOf([ + 'cover', + 'contain', + 'stretch', + 'repeat', + 'center', + ]), + /** + * A unique identifier for this element to be used in UI Automation + * testing scripts. + * + * See https://facebook.github.io/react-native/docs/image.html#testid + */ + testID: PropTypes.string, + /** + * Invoked on mount and layout changes with + * `{nativeEvent: {layout: {x, y, width, height}}}`. + * + * See https://facebook.github.io/react-native/docs/image.html#onlayout + */ + onLayout: PropTypes.func, + /** + * Invoked on load start. + * + * See https://facebook.github.io/react-native/docs/image.html#onloadstart + */ + onLoadStart: PropTypes.func, + /** + * Invoked on download progress with `{nativeEvent: {loaded, total}}`. + * + * See https://facebook.github.io/react-native/docs/image.html#onprogress + */ + onProgress: PropTypes.func, + /** + * Invoked on load error with `{nativeEvent: {error}}`. + * + * See https://facebook.github.io/react-native/docs/image.html#onerror + */ + onError: PropTypes.func, + /** + * Invoked when a partial load of the image is complete. + * + * See https://facebook.github.io/react-native/docs/image.html#onpartialload + */ + onPartialLoad: PropTypes.func, + /** + * Invoked when load completes successfully. + * + * See https://facebook.github.io/react-native/docs/image.html#onload + */ + onLoad: PropTypes.func, + /** + * Invoked when load either succeeds or fails. + * + * See https://facebook.github.io/react-native/docs/image.html#onloadend + */ + onLoadEnd: PropTypes.func, +};