From cadaf26cde031f1968d4992dd3a7bf4bb556920c Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Fri, 9 Feb 2024 06:31:31 -0800 Subject: [PATCH] Fix clang warning for -Winconsistent-missing-destructor-override (#42942) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42942 Instance derives from jsinspector_modern::InstanceTargetDelegate, which defines a virtual destructor, but Instance does not mark its destructor with override. ## Changelog [Internal] Reviewed By: cipolleschi Differential Revision: D53609922 fbshipit-source-id: b30df7d59478fa72b53ddc2eeb04c291a6f5f9eb --- packages/react-native/ReactCommon/cxxreact/Instance.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/cxxreact/Instance.h b/packages/react-native/ReactCommon/cxxreact/Instance.h index 5b070997a34f43..df63690f0c2080 100644 --- a/packages/react-native/ReactCommon/cxxreact/Instance.h +++ b/packages/react-native/ReactCommon/cxxreact/Instance.h @@ -41,7 +41,7 @@ struct InstanceCallback { class RN_EXPORT Instance : private jsinspector_modern::InstanceTargetDelegate { public: - ~Instance(); + ~Instance() override; void initializeBridge( std::unique_ptr callback, std::shared_ptr jsef,