Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app:bundleReleaseJsAndAssets depends on har-validator bin #13412

Closed
bilby91 opened this issue Apr 9, 2017 · 1 comment
Closed

app:bundleReleaseJsAndAssets depends on har-validator bin #13412

bilby91 opened this issue Apr 9, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@bilby91
Copy link

bilby91 commented Apr 9, 2017

Description

Android gradle task app:bundleReleaseJsAndAssets depends on har-validator. har-validator is a dependency of the request package. The current constraint for request is ^2.79.0. Since request 2.80 they updated har-validator to version 4.2 and this new version doesn't come with the bin executable, they split the project into har-cli. This generated an issue when having request >= 2.80.

Solution

Possible solutions could be to force 2.79 in request or add har-cli as a dependency. I really don't now source code during the building is the responsable for the hal-validator call.

Additional Information

  • React Native version: 0.41.2
  • Platform: Android
  • Development Operating System: macOS 10.12.3 (16D32)
  • Dev tools: SDK Version 23. Gradle 1.5.0
@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants