Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] Change to any file in node_modules requires restart #1439

Closed
brentvatne opened this issue May 29, 2015 · 7 comments
Closed

[Packager] Change to any file in node_modules requires restart #1439

brentvatne opened this issue May 29, 2015 · 7 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@brentvatne
Copy link
Collaborator

On master after today's sync, any changes to JS inside of node_modules requires a packager restart in order to take effect, and they will not be picked up for auto-reload. In contrast, on v0.5.0-rc, auto-reload works and a packager restart is not required.

It is useful sometimes to modify JS inside of node_modules directly for debugging purposes.

@JohnyDays
Copy link
Contributor

This used to already be the case for symlinked folders, usually created by npm link facebook/watchman#105

@tadeuzagallo
Copy link
Contributor

I added a rule to the packager to ignore node_modules in order to unbreak the test builds on Travis, but I understand that's not ideal, sorry about that.

@JohnyDays
Copy link
Contributor

@tadeuzagallo can I get a hint on where this rule is and how I can disable it? I'm currently using master and even changing this manually would speed up my development. Thanks!

@brentvatne brentvatne assigned tadeuzagallo and unassigned amasad Jun 2, 2015
@tadeuzagallo
Copy link
Contributor

It's set in: https://github.com/facebook/react-native/blob/master/packager/react-packager/src/FileWatcher/index.js#L70, sorry about that, I already know how to fix it, just didn't have the time to do so yet.

@brentvatne
Copy link
Collaborator Author

Thanks @tadeuzagallo 😄

@JohnyDays
Copy link
Contributor

Had found with with grep, sorry I didn't update this issue. Glad to know I found the right one though 👍

@tadeuzagallo
Copy link
Contributor

Oops, this has already been fixed.

@facebook facebook locked as resolved and limited conversation to collaborators Jun 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants