Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing clearTimeout in Vibration.js #15464

Closed
varungupta85 opened this issue Aug 11, 2017 · 1 comment
Closed

Fix missing clearTimeout in Vibration.js #15464

varungupta85 opened this issue Aug 11, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@varungupta85
Copy link
Contributor

I am sorry that I have to remove the issue template. I wanted to first clarify with the react-native team if they consider below as a bug in which case I will be willing to submit a PR.

I realized that in the Vibration.js file (link below), there are a couple of calls to setTimeout without corresponding calls to clearTimeout to clean the handlers.

setTimeout(() => vibrateScheduler(++_id, pattern, repeat, 1), pattern[0]);

I am not sure if this is a bug or not. I found it while I was going through all the calls made to setTimeout in my project to make sure that the handlers are cleared.

If it is a bug, I would be happy to submit a PR.

@pull-bot
Copy link

pull-bot commented Oct 9, 2017

Hey, thanks for reporting this issue!

It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

I am going to close this, but feel free to open a new issue that meets the requirements set forth in the template. Thanks!

@hramos hramos closed this as completed Oct 9, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Oct 9, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants