Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Reloading Maximum call stack size exceeded error with circular reference #16613

Closed
codebymikey opened this issue Oct 31, 2017 · 6 comments
Closed
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@codebymikey
Copy link

Carrying on from #7288 which has been opened for over a year.

Say, there are two files a.js and b.js.

a.js:

require('./b');

b.js:

require('./a')

After making a change to one of these files, with Hot Reloading enabled, it will run into an infinite situation and finally throw a Maximum call stack size exceeded error.

Even if I use a dynamic require in a function, such as what in b.js:

function f(){
  require('./a')
}

This is a pretty serious issue.

@react-native-bot
Copy link
Collaborator

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Hey @codebymikey, thanks for posting this! It looks like your issue is missing some required information. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce your issue. I am going to close this, but please feel free to open a new issue with the additional information provided. Thanks!

How to ContributeWhat to Expect from Maintainers

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Oct 31, 2017
@anonrig
Copy link

anonrig commented Jan 14, 2018

ffs, this is getting frustrating.

@realart
Copy link

realart commented Jan 31, 2018

This is a show-stopper for the entire framework and reason why I haven't done anything in React for past 5 months.

@react-native-bot
Copy link
Collaborator

This issue is missing some required information and has been closed. For anyone running into this issue, please go ahead and open a new issue, making sure to fill in the template.

@hramos
Copy link
Contributor

hramos commented Feb 13, 2018

This is now fixed in master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants