Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests][Flow] Use flow-bin so new releases to Flow don't break RN tests #1800

Closed
ide opened this issue Jun 30, 2015 · 4 comments
Closed

[Tests][Flow] Use flow-bin so new releases to Flow don't break RN tests #1800

ide opened this issue Jun 30, 2015 · 4 comments
Assignees
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Jun 30, 2015

Whoever is on-call probably wants to take a look at this --

Flow 0.13.1 was published recently and when the tests run brew reinstall flow they get the latest version. The tests fail fast if they aren't on Flow 0.12 so the tests are complaining about a Flow version mismatch.

AFAIK brew doesn't have an easy way to install an old version of a package so the recommended way is to upload a versioned formula to https://github.com/Homebrew/homebrew-versions and run:

brew install homebrew/versions/flow-0.12.0

(btw the formula naming scheme seems pretty shortsighted... following the pattern there, lib v1.1 would be named lib11.rb but so would lib v11! So probably best to keep the dots in the version string and call the formula something like flow-0.12.0.rb)

@ide
Copy link
Contributor Author

ide commented Jun 30, 2015

One thing that's kind of burdensome for the Flow team is that each new Flow release would need to publish a versioned formula to homebrew-versions. Maybe if the release process is scriptable it won't be an issue.

cc @jeffmo @gabelevi, you guys were the most recent publishers of flow.rb

@jeffmo
Copy link
Contributor

jeffmo commented Jun 30, 2015

I think @gabelevi has discussed this before (and so there must have been a reason this option wasn't taken) -- but flow-bin seems like a good option since it's an npm package that's semver and will point at the "right" version of flow no matter what the latest version in brew is...

@gabelevi care to chime in? I'm sure there's context I'm not aware of here.

@ide ide changed the title [Tests][Flow] CI tests are failing due to Flow version mismatch [Tests][Flow] Use flow-bin so new releases to Flow don't break RN tests Jul 2, 2015
@brentvatne
Copy link
Collaborator

ping @gabelevi

@brentvatne
Copy link
Collaborator

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out it's new home: https://productpains.com/post/react-native/testsflow-use-flow-bin-so-new-releases-to-flow-dont-break-rn-tests

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants