Android: After the app reloads, we're stuck with a dead thread because of SingleThreadAsserter

[SudoPlz]

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 8.4.0
Yarn: 1.5.1
npm: 5.3.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.0 => 0.53.0

Expected Behavior

I would expect the SingleThreadAsserter to clear the mThread value after the app reloads, so that a new thread can be used on every assertion from that point in.

react-native/ReactAndroid/src/main/java/com/facebook/react/common/SingleThreadAsserter.java

Line 23 in 26684cf

mThread = current;

Actual Behavior

Instead, the SingleThreadAsserter locks to the thread it was created with, so when the app reloads, and that thread dies we're stuck with a dead thread, which causes all subsequent assertions to fail.
Almost every uiManager method requires that assertion, so that's a big issue.

Steps to Reproduce

Here's a repo that suffers from that issue.
https://github.com/SudoPlz/react-native-synchronous-list

1. Download
2. cd RNExample
3. yarn install
4. Run the android project.

All works well until you reload. After the reload we get:

FATAL EXCEPTION: main
 Process: com.rnexample, PID: 8519
 java.lang.AssertionError
     at com.facebook.infer.annotation.Assertions.assertCondition(Assertions.java:66)
     at com.facebook.react.common.SingleThreadAsserter.assertNow(SingleThreadAsserter.java:27)
     at com.facebook.react.uimanager.ShadowNodeRegistry.getNode(ShadowNodeRegistry.java:67)
     at com.facebook.react.uimanager.UIImplementation.createView(UIImplementation.java:278)
     at com.facebook.react.uimanager.UIManagerModule.createView(UIManagerModule.java:364)
     at com.sudoplz.rnsynchronouslistmanager.Views.SyncRootView$3.run(SyncRootView.java:172)
     at android.os.Handler.handleCallback(Handler.java:751)
     at android.os.Handler.dispatchMessage(Handler.java:95)
     at android.os.Looper.loop(Looper.java:154)
     at android.app.ActivityThread.main(ActivityThread.java:6119)
     at java.lang.reflect.Method.invoke(Native Method)
     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

[react-native-bot]

Thanks for posting this! It looks like your issue may refer to an older version of React Native. Can you reproduce the issue on the latest release, v0.54.0?

Thank you for your contributions.

_{How to Contribute • What to Expect from Maintainers}

[SudoPlz]

Same exact issue on 0.54.0 yes.

[CodeRabbitYu]

same this question

[SudoPlz]

Since I don't see anyone responding to this, I'll try to use reflection to change the mThread value to null locally.
That's definitely a hack but I have no clue what else I can do.

https://github.com/wix/react-native-navigation/blob/8b034b2ebb95f482b594a467bd98942f0bce16ce/android/app/src/main/java/com/reactnativenavigation/utils/ReflectionUtils.java#L9

[SudoPlz]

Anyone? What is even the purpose of the SingleThreadAsserter ??

[pocketNelson]

I've been integrating ReactNative into an existing project that is mainly built on Fragments. I'm experiencing this using the react-native-android-fragment library. Yes, any kind of reload kicks the fragment off the thread. I guess, I can just try to listen for this failure then call the ReactFragment hosting my material again?

[janicduplessis]

@SudoPlz The goal of this class is to validate that some code is always run from the same thread. I guess a proper fix would be to add a reset method and call it when the native modules that use it gets invalidated (onCatalystInstanceDestroy method).

If you'd like to open up a PR to fix it that would be great.

[SudoPlz]

I'm not sure I know how to do that @janicduplessis do you mind elaborating a bit more? I'd be grateful.

[janicduplessis]

I had a quick look at the code and is it possible that you are holding on to an old instance of ReactApplicationContext? I think you should use ReactInstanceManager##getCurrentReactContext to make sure you have the proper one like the code in ReactRootView does.

You could override

react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java

Line 356 in 2b6599e

public void startReactApplication(

to get the ReactInstanceManager since it is private in ReactRootView sadly.

[SudoPlz]

Got it, always requesting the current react application context fixed the issue, thank you so much @janicduplessis !