Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18nManager.swapLeftAndRightInRTL() doesn't work #19942

Closed
sajaddp opened this issue Jun 28, 2018 · 4 comments
Closed

I18nManager.swapLeftAndRightInRTL() doesn't work #19942

sajaddp opened this issue Jun 28, 2018 · 4 comments
Labels
Bug Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@sajaddp
Copy link

sajaddp commented Jun 28, 2018

Environment

Environment:
OS: Windows 10
Node: 10.5.0
Yarn: 1.7.0
npm: 6.1.0
Watchman: Not Found
Xcode: N/A
Android Studio: Version 3.1.0.0 AI-173.4720617

Packages: (wanted => installed)
react: ^16.4.1 => 16.4.1
react-native: ^0.55.4 => 0.55.4

Description

As an RTL native language, I should say that while using the following command in the native RTL apps, left and right mustn't be swapped!
I18nManager.forceRTL(true);
Apparently, swapLeftAndRightInRTL is for avoiding this swape, but each of the following commands does not make any changes
I18nManager.swapLeftAndRightInRTL(false);
and
I18nManager.swapLeftAndRightInRTL(true);
Please go through this problem.

Note: in native RTL apps, while using I18nManager.forceRTL(true), two conditions may happen in the first run:

  1. User's Android language is set to an RTL language (e.g. Arabic, Persian etc.) and what is displayed is the same for the other runs.
  2. User's Android language is set to an LTR language (e.g. English) and the first display is mirrored.
    Therefore, if swapLeftAndRightInRTL works properly, the problem can be fixed.
@sajaddp
Copy link
Author

sajaddp commented Jul 28, 2018

...

@stale
Copy link

stale bot commented Oct 27, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 27, 2018
@sajaddp
Copy link
Author

sajaddp commented Oct 29, 2018

This problem still exists on latest version

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 29, 2018
@hramos hramos removed the Bug Report label Feb 6, 2019
@Titozzz
Copy link
Collaborator

Titozzz commented Mar 19, 2019

Hello there 👋 this issue doesn't have a repro (which means, a react-native init-ed project with the minimal changes that leads to creating the same issue you are reporting). Unfortunately, I have no way of helping you in a meaningful way – there is no easy way for me to recreate the situation and check that the issue reported is still there when changing the code.

@Titozzz Titozzz closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants