-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android TV] Touchable navigation not working with D-Pad in RN 57 #21233
Comments
I've just added an Apple tvOS issue (#21295) and I'm wondering if this might be related? You mentioned that you can come to the 'end' of the list of 3 items when navigating - did you try selecting the element after doing so? That could indicate whether it's the navigation that's failing, or just the opacity change (which would imply that it's just the focus handler failing). |
I think it's unrelated as the Also its a bit unclear from my example but the number of items in the list does not affect the number of "selected element" sounds that play, it always remains the same indicating something offscreen or some list which is not visible is being cycled. |
Understood - I was hoping that the same work might be able to fix both, but sounds like that was optimistic of me! |
I built a small android tv demo app and on both real TV device and android emulator I am having D-pad navigation issue. Select key - is working fine and was able to confirm that event associated with onPress was happening. Because of this issue, I couldn't navigate through the app because there is no way for me to see which element the focus is on. I very much appreciate if this issue can get addressed as well.
Thanks! |
My company has embarked on a major project leveraging Android TV and React Native. This issue is a blocker for us. Can we get any information as to whether this is being worked on internally? I noticed this PR from a collaborator: #21143 |
Same as @craigrbruce. My company wants to make an Android TV app. And as I see from @Weetbix there are important blockers in building a complete Leanback experience app. |
@craigrbruce @acollazomayer Seems like this was a two-part issue: the actual event handler on Android had a bug (fixed in #21143), but even after that fix the navigation still can't be tracked because of the same highlight/opacity issue I was seeing on Apple tvOS further up. I opened a PR to fix the latter, and it's currently awaiting review (#21478) - it might be helpful to politely remind the reviewers on that thread that there's a user need for this to be fixed. |
Thanks for your work @gtebbutt .. I will leave some feedback. |
Environment
Description
This is a regression.
D-Pad on Android TV does not navigate between touchables anymore.
Previously, with some touchables on screen pressing the a D-Pad would select them in a natural way. However in RN 0.57.0 nothing happens.
The touchables can still be clicked with a mouse and behave as expected (ie make a sound, and opacity changes), so its potentially a D-Pad event issue.
There may be some kind of invisible popup or something as pressing down and up still make sounds. Ie start the example, and press down on the dpad twice. You will hear a selection sound. Pressing down again will not do anything until you press UP (indicating 3 cycling between 3 options).
Reproducible Demo
^ the above has been tested on
0.55
is is working fine, but is broken on0.57
If you want a project example you can checkout this and run it: https://github.com/Weetbix/reddit-tv/tree/upgrade-to-react-native-57-WIP
The text was updated successfully, but these errors were encountered: