Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need better handling of multiple inputs with secureTextEntry on iOS 12+ #25603

Closed
d3vhound opened this issue Jul 12, 2019 · 12 comments
Closed
Labels
Bug Needs: Issue Template This issue does not make use of the Issue Template, and may be missing necessary information. Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@d3vhound
Copy link

d3vhound commented Jul 12, 2019

So before iOS 12 we were able to have multiple inputs with secureTextEntry and the auto suggestions were correct or not there unless specified in props. It seems now with iOS 12 and above that if you render 3 inputs: 1 without secureTextEntry first, then the other 2 with secureTextEntry last, that no matter what, iOS 12> will always think the input before the first secureTextEntry input is an email field and will show email suggestions. iOS will also think that the second secureTextEntry input is also an email field and will show email suggestions. There's no way to hide it except for only have 1 secureTextEntry input. Even then the suggestions are determined by iOS and props are almost useless. This wasn't the case with iOS 11.

Reproduction:
https://snack.expo.io/BkxZysBZB

As you can see, when the iOS version is less than 12, this works as intended. We can have multiple inputs with the secureTextEntry prop and it will not show email suggestions on them.

Now, run that same snack on a physical device on the expo app that is on iOS 12+

Ignoring the autofill feature, you can see that by default, iOS will show auto suggestions for email on the second secureTextEntry input.

My questions to the react-native core team is: How do you handle multiple secureTextEntry inputs in iOS 12? It seems that we have to put up with the wrong auto suggestions types and just deal with it.

(Pictures for clarity)

iOS 11 first input:
Screen Shot 2019-07-12 at 1 03 18 AM

iOS 12 first input:
Screen Shot 2019-07-12 at 1 03 18 AM

iOS 11 third input:
Screen Shot 2019-07-12 at 1 02 55 AM

iOS 12 third input:
Screen Shot 2019-07-12 at 1 02 55 AM

@d3vhound d3vhound added the Bug label Jul 12, 2019
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Jul 12, 2019
@react-native-bot
Copy link
Collaborator

Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety?

👉 Click here if you want to take another look at the Bug Report issue template.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels Jul 12, 2019
@janicduplessis
Copy link
Contributor

You can use https://facebook.github.io/react-native/docs/textinput#textcontenttype to hint the OS about the type of input

@d3vhound
Copy link
Author

That’s the thing, on iOS 12 that prop and the autoCorrect one don’t work in regards to not showing the email suggestions on the 2nd secureTextEntry input.

@janicduplessis
Copy link
Contributor

Strange, maybe it is a bug in UIKit, not sure if we can do anything about it :(

@hbarylskyi
Copy link

hbarylskyi commented Aug 8, 2019

Yeah, in the app I'm working on currently this problem appears even if I have just two inputs: email and password. If I move focus from email to password and back, the password suggestion tooltip appears when email field is focused, and email suggestion tooltip appears when password is focused. Or no tooltip at all.

I'm using 0.60.4.

@diamont1001
Copy link

I have the same issue :(

@stale
Copy link

stale bot commented Nov 7, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 7, 2019
@hbarylskyi
Copy link

Still an issue. iOS 13.2

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 7, 2019
@hbarylskyi
Copy link

@hramos what does 'Needs author feedback' tag mean?

@hramos hramos added Needs: Issue Template This issue does not make use of the Issue Template, and may be missing necessary information. and removed Needs: Author Feedback labels Jan 21, 2020
@hramos
Copy link
Contributor

hramos commented Jan 21, 2020

Fixed the label - this issue does not make use of the template, and it's missing necessary information. @hbarylskyi feel free to open a new issue that makes use of the issue template, as this one might get closed if it's not edited soon.

@stale
Copy link

stale bot commented Apr 21, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 21, 2020
@stale
Copy link

stale bot commented Apr 28, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Apr 28, 2020
@facebook facebook locked as resolved and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Needs: Issue Template This issue does not make use of the Issue Template, and may be missing necessary information. Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

6 participants