Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotReload not working #25851

Closed
asalhallak opened this issue Jul 28, 2019 · 4 comments
Closed

HotReload not working #25851

asalhallak opened this issue Jul 28, 2019 · 4 comments
Labels
Bug Resolution: Locked This issue was locked by the bot.

Comments

@asalhallak
Copy link

HotReload not working, changing in reader method not reflecting changes to UI

React Native version:
react-native: 0.60.4
System:
OS: macOS 10.14.5
CPU: (8) x64 Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz
Memory: 145.45 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.17.3
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.0
System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5522156
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.4 => 0.60.4
npmGlobalPackages:
react-native-cli: 2.0.1

Steps To Reproduce

  1. react-native init MyAwesomeProject --template typescript
  2. enable hot reload
  3. change any text
@asalhallak asalhallak added the Bug label Jul 28, 2019
@ceydamehves
Copy link

same here on windows 10.

React Native Version:

react-native-cli: 2.0.1
react-native: 0.60.4

@YouriT
Copy link

YouriT commented Aug 19, 2019

Neither does it work without TypeScript template.

Some additional repro steps:

System: Mac 10.14.3
react-native-cli: 2.0.1
react-native: 0.60.5

$ brew install watchman
$ brew tap AdoptOpenJDK/openjdk
$ brew cask install adoptopenjdk8
$ yarn global add react-native-cli
$ react-native-cli init AwesomeProject
$ cd AwesomeProject
$ yarn start
$ react-native run-ios # iPhone X 12.4 gets launched and gets the app installed
  • CMD+D => Enable Hot Reloading
  • Edited App.js and changed App.js in App
  • Saved
  • "Hot Reloading" gray popover appears but "App.js" stayed "App.js" where I was expecting "App"

So only difference is that NodeJS is install through nvm and is therefore located at $HOME/.nvm/versions/node/v10.15.3/bin/node but is available in $PATH.

Live Reloading works fine but is painful.

@edelgarat
Copy link

edelgarat commented Aug 24, 2019

video sample
https://youtu.be/U_Ckn_N_94g

my info

react-native info
info Fetching system and libraries information...
System:
    OS: macOS 10.14.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 1.27 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.8.0 - /usr/local/bin/node
    npm: 6.11.2 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.3, 29.0.2
      System Images: android-28 | Intel x86 Atom_64
  IDEs:
    Android Studio: 3.4 AI-183.6156.11.34.5692245
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6 
    react-native: 0.60.5 => 0.60.5 
  npmGlobalPackages:
    react-native-cli: 2.0.1

@gaearon
Copy link
Collaborator

gaearon commented Sep 11, 2019

React Native 0.61 includes a complete reimplementation of this mechanism called Fast Refresh. It's not out yet as stable, but you can already try React Native 0.61 RC 3.

I'll close and lock this because the implementation is completely different. So if there are still problems after you upgrade to 0.61, please file a new issue with full reproducing instructions (and preferably, a project). Thanks!

@gaearon gaearon closed this as completed Sep 11, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Sep 11, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants