Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor update: React Native core source code is moving from root to packages/react-native/ #36439

Closed
hoxyq opened this issue Mar 10, 2023 · 2 comments
Assignees
Labels

Comments

@hoxyq
Copy link
Contributor

hoxyq commented Mar 10, 2023

Hi all,

TL;DR: We’re moving a lot of the React Native code inside the packages/react-native/ folder of this repository. This issue serves as a heads up and a place to report any issues that come up.

What is happening?

We’re moving the react-native core code from the root folder and subfolders (like ReactCommon, React and ReactAndroid) inside the packages/react-native subfolder. This is a major step forward to proper monorepo setup, which was originally described in monorepo RFC. We expect this to improve developer experience for contributors of react-native. You can get a preview of how it looks by checking this PR.

What does this mean for me?

If you’re a React Native user: nothing will change for you. You can stop reading this issue as this change is completely transparent for you.
If you’re a React Native contributor: you will have to rebase your PRs on top of main and make sure you follow the new file structure. Similarly, if you’re maintaining a fork of React Native, you will have to adapt to the new file structure.

When is this happening?

We’re looking into merging this change on Wednesday 15.03.2023 as a first attempt. We might need to revert the change if it causes problems on our internal setup, and we’ll attempt to re-land in the immediate future.

What should I do if anything breaks?

We foresee that the most impacted folks are contributors with open PRs and fork maintainers. Git should help you while rebasing as the changes are mostly files being moved, and automatic rebases should just work.

If you’re facing issues or problems, please comment on this issue and link your repo / PR.

@hoxyq hoxyq added the RN Team label Mar 10, 2023
@hoxyq hoxyq pinned this issue Mar 10, 2023
@hoxyq
Copy link
Contributor Author

hoxyq commented Mar 15, 2023

Quick update

We had difficulties with merging it, which were not related to the changes themselves.
This will be fixed today and we will try again tomorrow (16.03) morning GMT.

UPD: Successfully landed on 17.03.

@hoxyq
Copy link
Contributor Author

hoxyq commented Jun 29, 2023

Closing this as we have successfully released 0.72.

@hoxyq hoxyq closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants