Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox devtools #492

Closed
iamdustan opened this issue Mar 30, 2015 · 8 comments
Closed

firefox devtools #492

iamdustan opened this issue Mar 30, 2015 · 8 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@iamdustan
Copy link

What would it take to support Firefox Devtools as well? I suspect that facebook/react-devtools#56 may be a blocker.

@vjeux
Copy link
Contributor

vjeux commented Mar 30, 2015

Nothing. It should work if you update the applescript to open Firefox instead of Chrome. https://github.com/facebook/react-native/blob/master/packager/launchChromeDevTools.applescript#L13

Do you want to try it out?

@iamdustan
Copy link
Author

Trying to understand this.

Initially the whole thing errors. Removing things and going step by step my first issue is:

execution error: plugin-container got an error: every window doesn’t understand the “count” message. (-1708)

this is referring to

if (count every window) = 0 then
  make new window
end if

I’m assuming that Fx doesn’t have every window or it is done in a different way... do you have any good Applescript references?

@iamdustan
Copy link
Author

Firefox has poor (relatively no) applescript support. I’m exploring other options for this.

@iamdustan
Copy link
Author

Stepping it up to a slightly larger discussion, does it make sense to change the applescript approach to something with Webdriver for Windows (and Linux) support?

@iamdustan
Copy link
Author

WIP incomplete support: https://github.com/facebook/react-native/compare/master...iamdustan:fx-dev-tools?expand=1

  1. It assumes Firefox Developer Edition is already open.
  2. It blindly opens more tabs (there isn’t a good way to view and grab active tabs that I’m aware of)

@vjeux
Copy link
Contributor

vjeux commented Mar 30, 2015

The applescript is just there to open chrome/firefox on the right page, after the js opens a websocket to the node server and everything runs from there

@iamdustan
Copy link
Author

@vjeux by everything runs from there I assume that the node server just pipes the JS back and forth between the browser and native processes? Or is the js running on the node instance and having it’s results piped to the browser and native processes?

@vjeux
Copy link
Contributor

vjeux commented Mar 30, 2015

You probably want to look at the debugger.html source that does the piping. JS is running inside of the browser.
https://github.com/facebook/react-native/blob/master/packager/debugger.html#L34-L62

@facebook facebook locked as resolved and limited conversation to collaborators May 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants