From 93249fa5571009a547b619580e0459b68554c287 Mon Sep 17 00:00:00 2001 From: Hector Ramos Date: Mon, 26 Feb 2018 12:20:14 -0800 Subject: [PATCH 1/5] Use env. var danger token --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index dc428d3a0b75af..0a38cf0c40e413 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -548,7 +548,7 @@ jobs: name: Analyze Pull Request command: | if [ -n "$CIRCLE_PR_NUMBER" ]; then - cd bots && DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" yarn danger + cd bots && DANGER_GITHUB_API_TOKEN=$DANGER_GITHUB_API_TOKEN yarn danger else echo "Skipping pull request analysis." fi From b4574622e9368ff692352419be4e007a30493abe Mon Sep 17 00:00:00 2001 From: Hector Ramos Date: Mon, 26 Feb 2018 12:26:01 -0800 Subject: [PATCH 2/5] temporarily re-enable danger on forks --- .circleci/config.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 0a38cf0c40e413..073446fef9d470 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -547,11 +547,11 @@ jobs: - run: name: Analyze Pull Request command: | - if [ -n "$CIRCLE_PR_NUMBER" ]; then + # if [ -n "$CIRCLE_PR_NUMBER" ]; then cd bots && DANGER_GITHUB_API_TOKEN=$DANGER_GITHUB_API_TOKEN yarn danger - else - echo "Skipping pull request analysis." - fi + # else + # echo "Skipping pull request analysis." + # fi when: always - run: name: Analyze Code From ecbec6c976426e9dd31fb5d0a2b21689c618e798 Mon Sep 17 00:00:00 2001 From: Hector Ramos Date: Mon, 26 Feb 2018 12:29:09 -0800 Subject: [PATCH 3/5] temporarily re-enable danger on forks --- .circleci/config.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 073446fef9d470..67bc3a6e0548bd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -535,13 +535,13 @@ jobs: - run: name: Install Additional Dependencies command: | - if [ -n "$CIRCLE_PR_NUMBER" ]; then +# if [ -n "$CIRCLE_PR_NUMBER" ]; then yarn add github@0.2.4 cd bots yarn install --non-interactive --cache-folder ~/.cache/yarn - else - echo "Skipping dependency installation." - fi +# else +# echo "Skipping dependency installation." +# fi - save-cache: *save-cache-analysis - run: From d6625fdd1e13f415d25e0505dfe895595e73370a Mon Sep 17 00:00:00 2001 From: Hector Ramos Date: Mon, 26 Feb 2018 12:30:53 -0800 Subject: [PATCH 4/5] temporarily re-enable danger on forks --- .circleci/config.yml | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 67bc3a6e0548bd..4b6e1a455809e7 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -535,23 +535,15 @@ jobs: - run: name: Install Additional Dependencies command: | -# if [ -n "$CIRCLE_PR_NUMBER" ]; then - yarn add github@0.2.4 - cd bots - yarn install --non-interactive --cache-folder ~/.cache/yarn -# else -# echo "Skipping dependency installation." -# fi + yarn add github@0.2.4 + cd bots + yarn install --non-interactive --cache-folder ~/.cache/yarn - save-cache: *save-cache-analysis - run: name: Analyze Pull Request command: | - # if [ -n "$CIRCLE_PR_NUMBER" ]; then - cd bots && DANGER_GITHUB_API_TOKEN=$DANGER_GITHUB_API_TOKEN yarn danger - # else - # echo "Skipping pull request analysis." - # fi + cd bots && DANGER_GITHUB_API_TOKEN=$DANGER_GITHUB_API_TOKEN yarn danger when: always - run: name: Analyze Code From dfa1f9a87dc03a1494725a415179b93bddda56d9 Mon Sep 17 00:00:00 2001 From: Hector Ramos Date: Mon, 26 Feb 2018 12:44:54 -0800 Subject: [PATCH 5/5] temporarily re-enable danger on forks --- .circleci/config.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4b6e1a455809e7..869119949746a3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -535,15 +535,23 @@ jobs: - run: name: Install Additional Dependencies command: | + # if [ -n "$CIRCLE_PR_NUMBER" ]; then yarn add github@0.2.4 cd bots yarn install --non-interactive --cache-folder ~/.cache/yarn + # else + # echo "Skipping dependency installation." + # fi - save-cache: *save-cache-analysis - run: name: Analyze Pull Request command: | + # if [ -n "$CIRCLE_PR_NUMBER" ]; then cd bots && DANGER_GITHUB_API_TOKEN=$DANGER_GITHUB_API_TOKEN yarn danger + # else + # echo "Skipping pull request analysis." + # fi when: always - run: name: Analyze Code