From 52f9fa668c443d12a393e94f794aafff9564951b Mon Sep 17 00:00:00 2001 From: Michael Blanchard Date: Mon, 26 Nov 2018 10:21:31 -0800 Subject: [PATCH 1/2] Fix: Add displayName to ActivityIndicator to fix jest snapshot displaying 'Component' instead of 'ActivityIndicator' --- Libraries/Components/ActivityIndicator/ActivityIndicator.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Libraries/Components/ActivityIndicator/ActivityIndicator.js b/Libraries/Components/ActivityIndicator/ActivityIndicator.js index 62df9c5783ded2..2ad685e1df2dc1 100644 --- a/Libraries/Components/ActivityIndicator/ActivityIndicator.js +++ b/Libraries/Components/ActivityIndicator/ActivityIndicator.js @@ -112,6 +112,7 @@ const ActivityIndicator = ( // $FlowFixMe - TODO T29156721 `React.forwardRef` is not defined in Flow, yet. const ActivityIndicatorWithRef = React.forwardRef(ActivityIndicator); +ActivityIndicatorWithRef.displayName = 'ActivityIndicator'; ActivityIndicatorWithRef.defaultProps = { animating: true, From 48395b28cb7957de3b31c4e70a54f973f9c573c4 Mon Sep 17 00:00:00 2001 From: Michael Blanchard Date: Mon, 26 Nov 2018 15:53:07 -0800 Subject: [PATCH 2/2] Tests: Add basic Snapshot test for ActivityIndicator --- .../__tests__/ActivityIndicator-test.js | 25 +++++++++++++++++++ .../ActivityIndicator-test.js.snap | 10 ++++++++ 2 files changed, 35 insertions(+) create mode 100644 Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js create mode 100644 Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap diff --git a/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js b/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js new file mode 100644 index 00000000000000..8be9b345bfa847 --- /dev/null +++ b/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js @@ -0,0 +1,25 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * + * @format + * @emails oncall+react_native + */ + +'use strict'; + +const React = require('React'); +const ReactTestRenderer = require('react-test-renderer'); +const ActivityIndicator = require('ActivityIndicator'); + +describe('ActivityIndicator', () => { + it('renders correctly', () => { + const instance = ReactTestRenderer.create( + , + ); + + expect(instance.toJSON()).toMatchSnapshot(); + }); +}); diff --git a/Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap b/Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap new file mode 100644 index 00000000000000..8a7181882a78dd --- /dev/null +++ b/Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap @@ -0,0 +1,10 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`ActivityIndicator renders correctly 1`] = ` + +`;