From 0b377fa72650fea2a2b7660a81d649428e3c6b44 Mon Sep 17 00:00:00 2001 From: ankit-tailor Date: Thu, 8 Sep 2022 17:00:34 +0530 Subject: [PATCH 1/2] fix: add mixed to aria-checked typings --- Libraries/Components/Button.js | 2 +- Libraries/Components/Pressable/Pressable.js | 2 +- Libraries/Components/Touchable/TouchableWithoutFeedback.js | 2 +- Libraries/Components/View/ViewPropTypes.js | 2 +- Libraries/Text/TextProps.js | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Libraries/Components/Button.js b/Libraries/Components/Button.js index b2bf05b5914c39..07b821748b51ac 100644 --- a/Libraries/Components/Button.js +++ b/Libraries/Components/Button.js @@ -153,7 +153,7 @@ type ButtonProps = $ReadOnly<{| * see https://reactnative.dev/docs/accessibility#accessibilitystate */ 'aria-busy'?: ?boolean, - 'aria-checked'?: ?boolean, + 'aria-checked'?: ?boolean | 'mixed', 'aria-disabled'?: ?boolean, 'aria-expanded'?: ?boolean, 'aria-selected'?: ?boolean, diff --git a/Libraries/Components/Pressable/Pressable.js b/Libraries/Components/Pressable/Pressable.js index 081a960e4a4ddb..b2d4ebc53bddd4 100644 --- a/Libraries/Components/Pressable/Pressable.js +++ b/Libraries/Components/Pressable/Pressable.js @@ -59,7 +59,7 @@ type Props = $ReadOnly<{| * see https://reactnative.dev/docs/accessibility#accessibilitystate */ 'aria-busy'?: ?boolean, - 'aria-checked'?: ?boolean, + 'aria-checked'?: ?boolean | 'mixed', 'aria-disabled'?: ?boolean, 'aria-expanded'?: ?boolean, 'aria-selected'?: ?boolean, diff --git a/Libraries/Components/Touchable/TouchableWithoutFeedback.js b/Libraries/Components/Touchable/TouchableWithoutFeedback.js index bb46921c8c9c75..2d8cf9a5a258eb 100755 --- a/Libraries/Components/Touchable/TouchableWithoutFeedback.js +++ b/Libraries/Components/Touchable/TouchableWithoutFeedback.js @@ -48,7 +48,7 @@ type Props = $ReadOnly<{| * see https://reactnative.dev/docs/accessibility#accessibilitystate */ 'aria-busy'?: ?boolean, - 'aria-checked'?: ?boolean, + 'aria-checked'?: ?boolean | 'mixed', 'aria-disabled'?: ?boolean, 'aria-expanded'?: ?boolean, 'aria-selected'?: ?boolean, diff --git a/Libraries/Components/View/ViewPropTypes.js b/Libraries/Components/View/ViewPropTypes.js index 13900583c26749..6a74020a9067de 100644 --- a/Libraries/Components/View/ViewPropTypes.js +++ b/Libraries/Components/View/ViewPropTypes.js @@ -497,7 +497,7 @@ export type ViewProps = $ReadOnly<{| * see https://reactnative.dev/docs/accessibility#accessibilitystate */ 'aria-busy'?: ?boolean, - 'aria-checked'?: ?boolean, + 'aria-checked'?: ?boolean | 'mixed', 'aria-disabled'?: ?boolean, 'aria-expanded'?: ?boolean, 'aria-selected'?: ?boolean, diff --git a/Libraries/Text/TextProps.js b/Libraries/Text/TextProps.js index 5ccb9f15e10383..ce8c2842431d71 100644 --- a/Libraries/Text/TextProps.js +++ b/Libraries/Text/TextProps.js @@ -84,7 +84,7 @@ export type TextProps = $ReadOnly<{| * see https://reactnative.dev/docs/accessibility#accessibilitystate */ 'aria-busy'?: ?boolean, - 'aria-checked'?: ?boolean, + 'aria-checked'?: ?boolean | 'mixed', 'aria-disabled'?: ?boolean, 'aria-expanded'?: ?boolean, 'aria-selected'?: ?boolean, From 658d314863218fed78999be34280bc058b043dfd Mon Sep 17 00:00:00 2001 From: ankit-tailor Date: Sat, 8 Oct 2022 14:12:38 +0530 Subject: [PATCH 2/2] fix: add mixed typing for aria checked --- Libraries/Components/View/ViewAccessibility.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/Components/View/ViewAccessibility.d.ts b/Libraries/Components/View/ViewAccessibility.d.ts index feeb7ed5736483..662fa372361973 100644 --- a/Libraries/Components/View/ViewAccessibility.d.ts +++ b/Libraries/Components/View/ViewAccessibility.d.ts @@ -53,7 +53,7 @@ export interface AccessibilityProps * see https://reactnative.dev/docs/accessibility#accessibilitystate */ 'aria-busy'?: boolean | undefined; - 'aria-checked'?: boolean | undefined; + 'aria-checked'?: boolean | 'mixed' | undefined; 'aria-disabled'?: boolean | undefined; 'aria-expanded'?: boolean | undefined; 'aria-selected'?: boolean | undefined;