Move yargs to a dependency to avoid script failures #35912
Conversation
|
Hi @cjhines! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: 208f559 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase |
|
@cortinico merged this pull request in 32931b7. |
|
Apologize this took a bit longer to land @cjhines |
|
This pull request has been reverted by 4e117cb. |
|
How come this was reverted? I'm maybe missing something from your workflow |
|
This was causing a failure on one of our internal builds and another engineer had to revert it. I'm attempting to land it again, will comment here if this happens |
Summary: yargs depdendency is unavailable on npm ci breaking certain CI builds. Fixes #35893 (comment) Changelog: [Internal] Prevent script failures on certain npm CI setups Pull Request resolved: #35912 Test Plan: waitforsandcastle Reviewed By: hoxyq Differential Revision: D43730837 Pulled By: cortinico fbshipit-source-id: 926182ee8482cd0c7fd183ea3e993a9322680567
|
re-merged here 5093e55 |
Summary: yargs depdendency is unavailable on npm ci breaking certain CI builds. Fixes facebook#35893 (comment) Changelog: [Internal] Prevent script failures on certain npm CI setups Pull Request resolved: facebook#35912 Test Plan: waitforsandcastle Reviewed By: hoxyq Differential Revision: D43186870 Pulled By: cortinico fbshipit-source-id: d7a64daac71b7554780152ed2150094add62ef0d
Summary: yargs depdendency is unavailable on npm ci breaking certain CI builds. Fixes facebook#35893 (comment) Changelog: [Internal] Prevent script failures on certain npm CI setups Pull Request resolved: facebook#35912 Test Plan: waitforsandcastle Reviewed By: hoxyq Differential Revision: D43730837 Pulled By: cortinico fbshipit-source-id: 926182ee8482cd0c7fd183ea3e993a9322680567
Summary
yargsdepdendency is unavailable onnpm cibreaking certain CI builds.Fixes #35893 (comment)
Changelog: [Internal]
Prevent script failures on certain npm CI setups
Test plan