Delete unused DOM files (#26387)

These used to be used by partial render. ReactDOMDispatcher ended up not being used in this way. Move shared DOM files to client. These are only used by client abstractions now. They're inlined in the Fizz code so they're no longer shared.
facebook · Mar 14, 2023 · 21aee59 · 21aee59
1 parent 56a3c18
commit 21aee59
Show file tree

Hide file tree

Showing 28 changed files with 25 additions and 145 deletions.
diff --git a/packages/react-dom-bindings/src/client/CSSPropertyOperations.js b/packages/react-dom-bindings/src/client/CSSPropertyOperations.js
@@ -7,7 +7,7 @@
 
 import {shorthandToLonghand} from './CSSShorthandProperty';
 
-import dangerousStyleValue from '../shared/dangerousStyleValue';
+import dangerousStyleValue from './dangerousStyleValue';
 import hyphenateStyleName from '../shared/hyphenateStyleName';
 import warnValidStyle from '../shared/warnValidStyle';
 

diff --git a/...-dom-bindings/src/shared/DOMNamespaces.js → ...-dom-bindings/src/client/DOMNamespaces.js b/...-dom-bindings/src/shared/DOMNamespaces.js → ...-dom-bindings/src/client/DOMNamespaces.js
diff --git a/...t-dom-bindings/src/shared/HTMLNodeType.js → ...t-dom-bindings/src/client/HTMLNodeType.js b/...t-dom-bindings/src/shared/HTMLNodeType.js → ...t-dom-bindings/src/client/HTMLNodeType.js
diff --git a/packages/react-dom-bindings/src/client/ReactDOMComponent.js b/packages/react-dom-bindings/src/client/ReactDOMComponent.js
@@ -55,14 +55,14 @@ import {
   setValueForStyles,
   validateShorthandPropertyCollisionInDev,
 } from './CSSPropertyOperations';
-import {HTML_NAMESPACE, getIntrinsicNamespace} from '../shared/DOMNamespaces';
+import {HTML_NAMESPACE, getIntrinsicNamespace} from './DOMNamespaces';
 import {
   getPropertyInfo,
   shouldIgnoreAttribute,
   shouldRemoveAttribute,
 } from '../shared/DOMProperty';
-import assertValidProps from '../shared/assertValidProps';
-import {DOCUMENT_NODE} from '../shared/HTMLNodeType';
+import assertValidProps from './assertValidProps';
+import {DOCUMENT_NODE} from './HTMLNodeType';
 import isCustomComponent from '../shared/isCustomComponent';
 import possibleStandardNames from '../shared/possibleStandardNames';
 import {validateProperties as validateARIAProperties} from '../shared/ReactDOMInvalidARIAHook';

diff --git a/packages/react-dom-bindings/src/client/ReactDOMComponentTree.js b/packages/react-dom-bindings/src/client/ReactDOMComponentTree.js
@@ -13,7 +13,7 @@ import type {ReactScopeInstance} from 'shared/ReactTypes';
 import type {
   ReactDOMEventHandle,
   ReactDOMEventHandleListener,
-} from '../shared/ReactDOMTypes';
+} from './ReactDOMEventHandleTypes';
 import type {
   Container,
   TextInstance,

diff --git a/packages/react-dom-bindings/src/client/ReactDOMEventHandle.js b/packages/react-dom-bindings/src/client/ReactDOMEventHandle.js
@@ -12,7 +12,7 @@ import type {ReactScopeInstance} from 'shared/ReactTypes';
 import type {
   ReactDOMEventHandle,
   ReactDOMEventHandleListener,
-} from '../shared/ReactDOMTypes';
+} from './ReactDOMEventHandleTypes';
 
 import {allNativeEvents} from '../events/EventRegistry';
 import {
@@ -21,7 +21,7 @@ import {
   doesTargetHaveEventHandle,
   addEventHandleToTarget,
 } from './ReactDOMComponentTree';
-import {ELEMENT_NODE} from '../shared/HTMLNodeType';
+import {ELEMENT_NODE} from './HTMLNodeType';
 import {listenToNativeEventForNonManagedEventTarget} from '../events/DOMPluginEventSystem';
 
 import {

diff --git a/...-dom-bindings/src/shared/ReactDOMTypes.js → ...gs/src/client/ReactDOMEventHandleTypes.js b/...-dom-bindings/src/shared/ReactDOMTypes.js → ...gs/src/client/ReactDOMEventHandleTypes.js
diff --git a/packages/react-dom-bindings/src/client/ReactDOMFloatClient.js b/packages/react-dom-bindings/src/client/ReactDOMFloatClient.js
@@ -16,8 +16,8 @@ import ReactDOMSharedInternals from 'shared/ReactDOMSharedInternals.js';
 const {Dispatcher} = ReactDOMSharedInternals;
 import {checkAttributeStringCoercion} from 'shared/CheckStringCoercion';
 
-import {DOCUMENT_NODE} from '../shared/HTMLNodeType';
-import {SVG_NAMESPACE} from '../shared/DOMNamespaces';
+import {DOCUMENT_NODE} from './HTMLNodeType';
+import {SVG_NAMESPACE} from './DOMNamespaces';
 import {
   validatePreloadArguments,
   validatePreinitArguments,

diff --git a/packages/react-dom-bindings/src/client/ReactDOMHostConfig.js b/packages/react-dom-bindings/src/client/ReactDOMHostConfig.js
@@ -61,16 +61,16 @@ import {
   getChildNamespace,
   SVG_NAMESPACE,
   MATH_NAMESPACE,
-} from '../shared/DOMNamespaces';
+} from './DOMNamespaces';
 import {
   ELEMENT_NODE,
   TEXT_NODE,
   COMMENT_NODE,
   DOCUMENT_NODE,
   DOCUMENT_TYPE_NODE,
   DOCUMENT_FRAGMENT_NODE,
-} from '../shared/HTMLNodeType';
-import dangerousStyleValue from '../shared/dangerousStyleValue';
+} from './HTMLNodeType';
+import dangerousStyleValue from './dangerousStyleValue';
 
 import {retryIfBlockedOn} from '../events/ReactDOMEventReplaying';
 

diff --git a/packages/react-dom-bindings/src/client/ReactDOMSelection.js b/packages/react-dom-bindings/src/client/ReactDOMSelection.js
@@ -6,7 +6,7 @@
  */
 
 import getNodeForCharacterOffset from './getNodeForCharacterOffset';
-import {TEXT_NODE} from '../shared/HTMLNodeType';
+import {TEXT_NODE} from './HTMLNodeType';
 
 /**
  * @param {DOMElement} outerNode

diff --git a/packages/react-dom-bindings/src/client/ReactInputSelection.js b/packages/react-dom-bindings/src/client/ReactInputSelection.js
@@ -8,7 +8,7 @@
 import getActiveElement from './getActiveElement';
 
 import {getOffsets, setOffsets} from './ReactDOMSelection';
-import {ELEMENT_NODE, TEXT_NODE} from '../shared/HTMLNodeType';
+import {ELEMENT_NODE, TEXT_NODE} from './HTMLNodeType';
 
 function isTextNode(node) {
   return node && node.nodeType === TEXT_NODE;

diff --git a/...m-bindings/src/shared/assertValidProps.js → ...m-bindings/src/client/assertValidProps.js b/...m-bindings/src/shared/assertValidProps.js → ...m-bindings/src/client/assertValidProps.js
diff --git a/...indings/src/shared/dangerousStyleValue.js → ...indings/src/client/dangerousStyleValue.js b/...indings/src/shared/dangerousStyleValue.js → ...indings/src/client/dangerousStyleValue.js
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {isUnitlessNumber} from './CSSProperty';
+import {isUnitlessNumber} from '../shared/CSSProperty';
 import {checkCSSPropertyStringCoercion} from 'shared/CheckStringCoercion';
 
 /**

diff --git a/packages/react-dom-bindings/src/client/getNodeForCharacterOffset.js b/packages/react-dom-bindings/src/client/getNodeForCharacterOffset.js
@@ -7,7 +7,7 @@
  * @flow
  */
 
-import {TEXT_NODE} from '../shared/HTMLNodeType';
+import {TEXT_NODE} from './HTMLNodeType';
 
 /**
  * Given any node return the first leaf node without children.

diff --git a/...m-bindings/src/shared/omittedCloseTags.js → ...m-bindings/src/client/omittedCloseTags.js b/...m-bindings/src/shared/omittedCloseTags.js → ...m-bindings/src/client/omittedCloseTags.js
diff --git a/packages/react-dom-bindings/src/client/setInnerHTML.js b/packages/react-dom-bindings/src/client/setInnerHTML.js
@@ -7,7 +7,7 @@
  * @flow
  */
 
-import {SVG_NAMESPACE} from '../shared/DOMNamespaces';
+import {SVG_NAMESPACE} from './DOMNamespaces';
 import createMicrosoftUnsafeLocalFunction from './createMicrosoftUnsafeLocalFunction';
 import {enableTrustedTypesIntegration} from 'shared/ReactFeatureFlags';
 

diff --git a/packages/react-dom-bindings/src/client/setTextContent.js b/packages/react-dom-bindings/src/client/setTextContent.js
@@ -7,7 +7,7 @@
  * @flow
  */
 
-import {TEXT_NODE} from '../shared/HTMLNodeType';
+import {TEXT_NODE} from './HTMLNodeType';
 
 /**
  * Set the textContent property of a node. For text updates, it's faster

diff --git a/...om-bindings/src/shared/voidElementTags.js → ...om-bindings/src/client/voidElementTags.js b/...om-bindings/src/shared/voidElementTags.js → ...om-bindings/src/client/voidElementTags.js
diff --git a/packages/react-dom-bindings/src/events/DOMPluginEventSystem.js b/packages/react-dom-bindings/src/events/DOMPluginEventSystem.js
@@ -43,7 +43,7 @@ import {
   getEventListenerSet,
   getEventHandlerListeners,
 } from '../client/ReactDOMComponentTree';
-import {COMMENT_NODE, DOCUMENT_NODE} from '../shared/HTMLNodeType';
+import {COMMENT_NODE, DOCUMENT_NODE} from '../client/HTMLNodeType';
 import {batchedUpdates} from './ReactDOMUpdateBatching';
 import getListener from './getListener';
 import {passiveBrowserEventsSupported} from './checkPassiveEvents';

diff --git a/packages/react-dom-bindings/src/events/getEventTarget.js b/packages/react-dom-bindings/src/events/getEventTarget.js
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {TEXT_NODE} from '../shared/HTMLNodeType';
+import {TEXT_NODE} from '../client/HTMLNodeType';
 
 /**
  * Gets the target node from a native browser event by accounting for

diff --git a/packages/react-dom-bindings/src/events/plugins/SelectEventPlugin.js b/packages/react-dom-bindings/src/events/plugins/SelectEventPlugin.js
@@ -23,7 +23,7 @@ import {registerTwoPhaseEvent} from '../EventRegistry';
 import getActiveElement from '../../client/getActiveElement';
 import {getNodeFromInstance} from '../../client/ReactDOMComponentTree';
 import {hasSelectionCapabilities} from '../../client/ReactInputSelection';
-import {DOCUMENT_NODE} from '../../shared/HTMLNodeType';
+import {DOCUMENT_NODE} from '../../client/HTMLNodeType';
 import {accumulateTwoPhaseListeners} from '../DOMPluginEventSystem';
 
 const skipSelectionChangeEvent =

diff --git a/packages/react-dom-bindings/src/server/DOMMarkupOperations.js b/packages/react-dom-bindings/src/server/DOMMarkupOperations.js
diff --git a/packages/react-dom-bindings/src/server/quoteAttributeValueForBrowser.js b/packages/react-dom-bindings/src/server/quoteAttributeValueForBrowser.js
diff --git a/packages/react-dom-bindings/src/shared/ReactDOMDispatcher.js b/packages/react-dom-bindings/src/shared/ReactDOMDispatcher.js
diff --git a/packages/react-dom/src/__tests__/ReactMount-test.js b/packages/react-dom/src/__tests__/ReactMount-test.js
@@ -9,7 +9,7 @@
 
 'use strict';
 
-const {COMMENT_NODE} = require('react-dom-bindings/src/shared/HTMLNodeType');
+const {COMMENT_NODE} = require('react-dom-bindings/src/client/HTMLNodeType');
 
 let React;
 let ReactDOM;

diff --git a/packages/react-dom/src/client/ReactDOMLegacy.js b/packages/react-dom/src/client/ReactDOMLegacy.js
@@ -27,7 +27,7 @@ import {
   DOCUMENT_NODE,
   ELEMENT_NODE,
   COMMENT_NODE,
-} from 'react-dom-bindings/src/shared/HTMLNodeType';
+} from 'react-dom-bindings/src/client/HTMLNodeType';
 
 import {
   createContainer,

diff --git a/packages/react-dom/src/client/ReactDOMRoot.js b/packages/react-dom/src/client/ReactDOMRoot.js
@@ -66,7 +66,7 @@ import {
   COMMENT_NODE,
   DOCUMENT_NODE,
   DOCUMENT_FRAGMENT_NODE,
-} from 'react-dom-bindings/src/shared/HTMLNodeType';
+} from 'react-dom-bindings/src/client/HTMLNodeType';
 
 import {
   createContainer,

diff --git a/packages/react-dom/src/test-utils/ReactTestUtils.js b/packages/react-dom/src/test-utils/ReactTestUtils.js
@@ -20,7 +20,7 @@ import {
   HostText,
 } from 'react-reconciler/src/ReactWorkTags';
 import {SyntheticEvent} from 'react-dom-bindings/src/events/SyntheticEvent';
-import {ELEMENT_NODE} from 'react-dom-bindings/src/shared/HTMLNodeType';
+import {ELEMENT_NODE} from 'react-dom-bindings/src/client/HTMLNodeType';
 import {
   rethrowCaughtError,
   invokeGuardedCallbackAndCatchFirstError,
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,7 @@ @@
      * @flow
      */
-    import {TEXT_NODE} from '../shared/HTMLNodeType';
+    import {TEXT_NODE} from './HTMLNodeType';
     /**
      * Given any node return the first leaf node without children.
@@ Expand Down @@