-
Notifications
You must be signed in to change notification settings - Fork 47.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
make testing builds for React/ReactDOM (#17915)
This PR introduces adds `react/testing` and `react-dom/testing`. - changes infra to generate these builds - exports act on ReactDOM in these testing builds - uses the new test builds in fixtures/dom In the next PR - - I'll use the new builds for all our own tests - I'll replace usages of TestUtils.act with ReactDOM.act.
- Loading branch information
1 parent
ace9e81
commit 3e9251d
Showing
26 changed files
with
474 additions
and
494 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
'use strict'; | ||
|
||
function checkDCE() { | ||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */ | ||
if ( | ||
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ === 'undefined' || | ||
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.checkDCE !== 'function' | ||
) { | ||
return; | ||
} | ||
if (process.env.NODE_ENV !== 'production') { | ||
// This branch is unreachable because this function is only called | ||
// in production, but the condition is true only in development. | ||
// Therefore if the branch is still here, dead code elimination wasn't | ||
// properly applied. | ||
// Don't change the message. React DevTools relies on it. Also make sure | ||
// this message doesn't occur elsewhere in this function, or it will cause | ||
// a false positive. | ||
throw new Error('^_^'); | ||
} | ||
try { | ||
// Verify that the code above has been dead code eliminated (DCE'd). | ||
__REACT_DEVTOOLS_GLOBAL_HOOK__.checkDCE(checkDCE); | ||
} catch (err) { | ||
// DevTools shouldn't crash React, no matter what. | ||
// We should still report in case we break this code. | ||
console.error(err); | ||
} | ||
} | ||
|
||
if (process.env.NODE_ENV === 'production') { | ||
// DCE check should happen before ReactDOM bundle executes so that | ||
// DevTools can report bad minification during injection. | ||
checkDCE(); | ||
module.exports = require('./cjs/react-dom-testing.production.min.js'); | ||
} else { | ||
module.exports = require('./cjs/react-dom-testing.development.js'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const ReactDOM = require('./src/client/ReactDOM'); | ||
|
||
// TODO: decide on the top-level export form. | ||
// This is hacky but makes it work with both Rollup and Jest. | ||
module.exports = ReactDOM.default || ReactDOM; |
Oops, something went wrong.