From c53cad6bbe018a5a1918f663dc7f0dd4a778ede4 Mon Sep 17 00:00:00 2001 From: gnoff Date: Fri, 26 Jan 2024 16:00:50 +0000 Subject: [PATCH] fix incorrect insertion order of stylesheets (#28108) ## Summary In the precendences Map every key is prefixed with `p`. This fixes one case where this is missing. ## How did you test this change? DiffTrain build for [763612647ceb66d95f728af896ca5e18a8181db8](https://github.com/facebook/react/commit/763612647ceb66d95f728af896ca5e18a8181db8) --- compiled/facebook-www/REVISION | 2 +- compiled/facebook-www/React-dev.classic.js | 2 +- compiled/facebook-www/ReactART-dev.modern.js | 2 +- compiled/facebook-www/ReactDOM-dev.classic.js | 4 ++-- compiled/facebook-www/ReactDOM-dev.modern.js | 4 ++-- compiled/facebook-www/ReactDOM-prod.classic.js | 8 ++++---- compiled/facebook-www/ReactDOM-prod.modern.js | 8 ++++---- compiled/facebook-www/ReactDOM-profiling.classic.js | 8 ++++---- compiled/facebook-www/ReactDOM-profiling.modern.js | 8 ++++---- compiled/facebook-www/ReactDOMTesting-dev.classic.js | 4 ++-- compiled/facebook-www/ReactDOMTesting-dev.modern.js | 4 ++-- compiled/facebook-www/ReactDOMTesting-prod.classic.js | 8 ++++---- compiled/facebook-www/ReactDOMTesting-prod.modern.js | 8 ++++---- 13 files changed, 35 insertions(+), 35 deletions(-) diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION index 3df3bd858fee4..d4cd2d7e02da0 100644 --- a/compiled/facebook-www/REVISION +++ b/compiled/facebook-www/REVISION @@ -1 +1 @@ -85b296e9b6ded4accd9ec3389297f95091fb1ac0 +763612647ceb66d95f728af896ca5e18a8181db8 diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js index 9669a4e2eb247..c26e70d98ba75 100644 --- a/compiled/facebook-www/React-dev.classic.js +++ b/compiled/facebook-www/React-dev.classic.js @@ -24,7 +24,7 @@ if (__DEV__) { ) { __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error()); } - var ReactVersion = "18.3.0-www-classic-af9ffe5b"; + var ReactVersion = "18.3.0-www-classic-a55e720b"; // ATTENTION // When adding new symbols to this file, diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js index 7cfa909c1d768..90f7e62f54188 100644 --- a/compiled/facebook-www/ReactART-dev.modern.js +++ b/compiled/facebook-www/ReactART-dev.modern.js @@ -66,7 +66,7 @@ if (__DEV__) { return self; } - var ReactVersion = "18.3.0-www-modern-2a25f03a"; + var ReactVersion = "18.3.0-www-modern-606c88be"; var LegacyRoot = 0; var ConcurrentRoot = 1; diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js index 495a9d6cbfcb1..dd741d142cf87 100644 --- a/compiled/facebook-www/ReactDOM-dev.classic.js +++ b/compiled/facebook-www/ReactDOM-dev.classic.js @@ -35045,7 +35045,7 @@ if (__DEV__) { return root; } - var ReactVersion = "18.3.0-www-classic-463bb300"; + var ReactVersion = "18.3.0-www-classic-b3425480"; function createPortal$1( children, @@ -45612,7 +45612,7 @@ if (__DEV__) { precedences.set("last", instance); } - precedences.set(precedence, instance); + precedences.set("p" + precedence, instance); this.count++; var onComplete = onUnsuspend.bind(this); instance.addEventListener("load", onComplete); diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js index 63125cd3f32a3..d7d9d42157e48 100644 --- a/compiled/facebook-www/ReactDOM-dev.modern.js +++ b/compiled/facebook-www/ReactDOM-dev.modern.js @@ -34866,7 +34866,7 @@ if (__DEV__) { return root; } - var ReactVersion = "18.3.0-www-modern-6f317449"; + var ReactVersion = "18.3.0-www-modern-1fddac1a"; function createPortal$1( children, @@ -46098,7 +46098,7 @@ if (__DEV__) { precedences.set("last", instance); } - precedences.set(precedence, instance); + precedences.set("p" + precedence, instance); this.count++; var onComplete = onUnsuspend.bind(this); instance.addEventListener("load", onComplete); diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js index 735d0e685ca61..ec7c2fa8f46a1 100644 --- a/compiled/facebook-www/ReactDOM-prod.classic.js +++ b/compiled/facebook-www/ReactDOM-prod.classic.js @@ -15830,7 +15830,7 @@ function insertStylesheetIntoRoot(root, resource) { node = nodes.getAttribute("data-precedence"); i = precedences.get("p" + node) || last; i === last && precedences.set("last", nodes); - precedences.set(node, nodes); + precedences.set("p" + node, nodes); this.count++; last = onUnsuspend.bind(this); nodes.addEventListener("load", last); @@ -16641,7 +16641,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1801 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-classic-bf108a56", + version: "18.3.0-www-classic-155e9f59", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2147 = { @@ -16671,7 +16671,7 @@ var internals$jscomp$inline_2147 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-www-classic-bf108a56" + reconcilerVersion: "18.3.0-www-classic-155e9f59" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2148 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -17008,4 +17008,4 @@ exports.useFormState = function () { exports.useFormStatus = function () { throw Error(formatProdErrorMessage(248)); }; -exports.version = "18.3.0-www-classic-bf108a56"; +exports.version = "18.3.0-www-classic-155e9f59"; diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js index ec4e3994393f2..1436151d8a841 100644 --- a/compiled/facebook-www/ReactDOM-prod.modern.js +++ b/compiled/facebook-www/ReactDOM-prod.modern.js @@ -16056,7 +16056,7 @@ function insertStylesheetIntoRoot(root, resource) { node = nodes.getAttribute("data-precedence"); i = precedences.get("p" + node) || last; i === last && precedences.set("last", nodes); - precedences.set(node, nodes); + precedences.set("p" + node, nodes); this.count++; last = onUnsuspend.bind(this); nodes.addEventListener("load", last); @@ -16164,7 +16164,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1760 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-modern-d5b75bf8", + version: "18.3.0-www-modern-ac114578", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2111 = { @@ -16195,7 +16195,7 @@ var internals$jscomp$inline_2111 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-www-modern-d5b75bf8" + reconcilerVersion: "18.3.0-www-modern-ac114578" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2112 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -16460,4 +16460,4 @@ exports.useFormState = function () { exports.useFormStatus = function () { throw Error(formatProdErrorMessage(248)); }; -exports.version = "18.3.0-www-modern-d5b75bf8"; +exports.version = "18.3.0-www-modern-ac114578"; diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js index 8ed043284c28a..6bd73a06b4a70 100644 --- a/compiled/facebook-www/ReactDOM-profiling.classic.js +++ b/compiled/facebook-www/ReactDOM-profiling.classic.js @@ -16599,7 +16599,7 @@ function insertStylesheetIntoRoot(root, resource) { node = nodes.getAttribute("data-precedence"); i = precedences.get("p" + node) || last; i === last && precedences.set("last", nodes); - precedences.set(node, nodes); + precedences.set("p" + node, nodes); this.count++; last = onUnsuspend.bind(this); nodes.addEventListener("load", last); @@ -17410,7 +17410,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1886 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-classic-4b1d2c60", + version: "18.3.0-www-classic-f5d53ab6", rendererPackageName: "react-dom" }; (function (internals) { @@ -17454,7 +17454,7 @@ var devToolsConfig$jscomp$inline_1886 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-www-classic-4b1d2c60" + reconcilerVersion: "18.3.0-www-classic-f5d53ab6" }); assign(Internals, { ReactBrowserEventEmitter: { @@ -17778,7 +17778,7 @@ exports.useFormState = function () { exports.useFormStatus = function () { throw Error(formatProdErrorMessage(248)); }; -exports.version = "18.3.0-www-classic-4b1d2c60"; +exports.version = "18.3.0-www-classic-f5d53ab6"; "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ && "function" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop && diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js index a5dc37d5f7932..4bd8cda4aaf1d 100644 --- a/compiled/facebook-www/ReactDOM-profiling.modern.js +++ b/compiled/facebook-www/ReactDOM-profiling.modern.js @@ -16819,7 +16819,7 @@ function insertStylesheetIntoRoot(root, resource) { node = nodes.getAttribute("data-precedence"); i = precedences.get("p" + node) || last; i === last && precedences.set("last", nodes); - precedences.set(node, nodes); + precedences.set("p" + node, nodes); this.count++; last = onUnsuspend.bind(this); nodes.addEventListener("load", last); @@ -16927,7 +16927,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1845 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-modern-2a25f03a", + version: "18.3.0-www-modern-606c88be", rendererPackageName: "react-dom" }; (function (internals) { @@ -16972,7 +16972,7 @@ var devToolsConfig$jscomp$inline_1845 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-www-modern-2a25f03a" + reconcilerVersion: "18.3.0-www-modern-606c88be" }); exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals; exports.createPortal = function (children, container) { @@ -17224,7 +17224,7 @@ exports.useFormState = function () { exports.useFormStatus = function () { throw Error(formatProdErrorMessage(248)); }; -exports.version = "18.3.0-www-modern-2a25f03a"; +exports.version = "18.3.0-www-modern-606c88be"; "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ && "function" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop && diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js index 0848d59f3adcf..bba40ffb47b4f 100644 --- a/compiled/facebook-www/ReactDOMTesting-dev.classic.js +++ b/compiled/facebook-www/ReactDOMTesting-dev.classic.js @@ -35669,7 +35669,7 @@ if (__DEV__) { return root; } - var ReactVersion = "18.3.0-www-classic-78856bf2"; + var ReactVersion = "18.3.0-www-classic-b09ceb48"; function createPortal$1( children, @@ -46368,7 +46368,7 @@ if (__DEV__) { precedences.set("last", instance); } - precedences.set(precedence, instance); + precedences.set("p" + precedence, instance); this.count++; var onComplete = onUnsuspend.bind(this); instance.addEventListener("load", onComplete); diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js index 1a0062ae1e5d0..dcd5723ed1978 100644 --- a/compiled/facebook-www/ReactDOMTesting-dev.modern.js +++ b/compiled/facebook-www/ReactDOMTesting-dev.modern.js @@ -35490,7 +35490,7 @@ if (__DEV__) { return root; } - var ReactVersion = "18.3.0-www-modern-64c7bec9"; + var ReactVersion = "18.3.0-www-modern-21fe6455"; function createPortal$1( children, @@ -46854,7 +46854,7 @@ if (__DEV__) { precedences.set("last", instance); } - precedences.set(precedence, instance); + precedences.set("p" + precedence, instance); this.count++; var onComplete = onUnsuspend.bind(this); instance.addEventListener("load", onComplete); diff --git a/compiled/facebook-www/ReactDOMTesting-prod.classic.js b/compiled/facebook-www/ReactDOMTesting-prod.classic.js index f2e5337b90bc9..820b6564e52b6 100644 --- a/compiled/facebook-www/ReactDOMTesting-prod.classic.js +++ b/compiled/facebook-www/ReactDOMTesting-prod.classic.js @@ -16159,7 +16159,7 @@ function insertStylesheetIntoRoot(root, resource) { node = nodes.getAttribute("data-precedence"); i = precedences.get("p" + node) || last; i === last && precedences.set("last", nodes); - precedences.set(node, nodes); + precedences.set("p" + node, nodes); this.count++; last = onUnsuspend.bind(this); nodes.addEventListener("load", last); @@ -16970,7 +16970,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1806 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-classic-af9ffe5b", + version: "18.3.0-www-classic-a55e720b", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2159 = { @@ -17000,7 +17000,7 @@ var internals$jscomp$inline_2159 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-www-classic-af9ffe5b" + reconcilerVersion: "18.3.0-www-classic-a55e720b" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2160 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -17488,4 +17488,4 @@ exports.useFormState = function () { exports.useFormStatus = function () { throw Error(formatProdErrorMessage(248)); }; -exports.version = "18.3.0-www-classic-af9ffe5b"; +exports.version = "18.3.0-www-classic-a55e720b"; diff --git a/compiled/facebook-www/ReactDOMTesting-prod.modern.js b/compiled/facebook-www/ReactDOMTesting-prod.modern.js index 78b3ba8eaf993..74c7d163dfc4f 100644 --- a/compiled/facebook-www/ReactDOMTesting-prod.modern.js +++ b/compiled/facebook-www/ReactDOMTesting-prod.modern.js @@ -16439,7 +16439,7 @@ function insertStylesheetIntoRoot(root, resource) { node = nodes.getAttribute("data-precedence"); i = precedences.get("p" + node) || last; i === last && precedences.set("last", nodes); - precedences.set(node, nodes); + precedences.set("p" + node, nodes); this.count++; last = onUnsuspend.bind(this); nodes.addEventListener("load", last); @@ -16547,7 +16547,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1765 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-modern-f302a037", + version: "18.3.0-www-modern-1e455221", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2122 = { @@ -16578,7 +16578,7 @@ var internals$jscomp$inline_2122 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-www-modern-f302a037" + reconcilerVersion: "18.3.0-www-modern-1e455221" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2123 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -16993,4 +16993,4 @@ exports.useFormState = function () { exports.useFormStatus = function () { throw Error(formatProdErrorMessage(248)); }; -exports.version = "18.3.0-www-modern-f302a037"; +exports.version = "18.3.0-www-modern-1e455221";