Skip to content

Commit

Permalink
ADD: disablePictureInPicture attribute for HTML5 videos (#15334)
Browse files Browse the repository at this point in the history
* ADD: disablePictureInPicture attribute for HTML5 videos

* ADD: disablePictureInPicture as DOMProperty and attribute

* Update: Replace camelCase with lowercase and vice-versa

* FIX: Missing comma on attribute (prettier)
  • Loading branch information
eek authored and cpojer committed Apr 25, 2019
1 parent 1eb2b89 commit f85aade
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions fixtures/attribute-behavior/src/attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,11 @@ const attributes = [
read: getSVGAttribute('direction'),
},
{name: 'disabled', tagName: 'input'},
{
name: 'disablePictureInPicture',
tagName: 'video',
read: getProperty('disablepictureinpicture'),
},
{
name: 'display',
tagName: 'svg',
Expand Down
1 change: 1 addition & 0 deletions packages/react-dom/src/shared/DOMProperty.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ const properties = {};
'default',
'defer',
'disabled',
'disablePictureInPicture',
'formNoValidate',
'hidden',
'loop',
Expand Down
1 change: 1 addition & 0 deletions packages/react-dom/src/shared/possibleStandardNames.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const possibleStandardNames = {
defer: 'defer',
dir: 'dir',
disabled: 'disabled',
disablepictureinpicture: 'disablePictureInPicture',
download: 'download',
draggable: 'draggable',
enctype: 'encType',
Expand Down

0 comments on commit f85aade

Please sign in to comment.