Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs are slower to update than other tags #1178

Closed
sophiebits opened this issue Feb 25, 2014 · 2 comments
Closed

Inputs are slower to update than other tags #1178

sophiebits opened this issue Feb 25, 2014 · 2 comments

Comments

@sophiebits
Copy link
Collaborator

If you compare:

http://jsfiddle.net/yannyann/6HeSr/

to this one where I've swapped out the input for a span:

http://jsfiddle.net/6HeSr/6/

then you'll notice the second one is about twice as fast to update. Maybe we can optimize ReactDOMInput to bring these more in line?

@jordwalke
Copy link
Contributor

I had a comment a long time ago (it might still be relevant). We shouldn't be reading from the DOM in order to reconcile because that's kind of the point of reconciling - to be able to detect changes without having to resort to touching the DOM. Not sure if it's possible to do the types of things we want without resorting to DOM touching.

@sophiebits
Copy link
Collaborator Author

We'll keep doing perf work but this doesn't need to stay open as a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants