-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We don't assert on warnings for tests that throw #12428
Comments
The reason the above test fails is because of this check: react/scripts/jest/matchers/toWarnDev.js Lines 88 to 92 in e9ba8ec
As PR #12081 mentions:
I'm not sure of the best way to handle this. If there was a way to detect this nesting combination ( |
Maybe I could add a lint rule to warn about the above combo? Update: This might be trickier than I thought, since it seems like we have 3 tests that don't work if the nesting order is reversed. (When we replay failed work, the warning is logged a second time- even though we only expect it once.) |
I think this shouldn't pass:
but it does.
The text was updated successfully, but these errors were encountered: