Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Fire Feature Flag #13554

Closed
3 tasks
nhunzaker opened this issue Sep 4, 2018 · 3 comments
Closed
3 tasks

React Fire Feature Flag #13554

nhunzaker opened this issue Sep 4, 2018 · 3 comments

Comments

@nhunzaker
Copy link
Contributor

There needs to be a feature flag for React 🔥. I thought I'd make an issue to track what that entails. I need some help to make this list, but roughly going off of React Fiber:

  • Add feature flag to ReactFeatureFlags
  • Execute the test suite with React Fire flagged (this probably needs to be a config setting in Jest, but I'm not sure where yet)
  • It might be nice to build react-dom with fire enabled for testing in the DOM Test Fixtures
@gaearon
Copy link
Collaborator

gaearon commented Sep 4, 2018

We'll definitely need a flag for Fire but we might also have separate feature flags for smaller changes within the current system (which we'll need to assess how much effort it is to migrate for real code).

@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 19, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants