Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapid successive calls to unloaded cache/resource items in Suspense results in a silent lockup #14097

Closed
tannerlinsley opened this issue Nov 5, 2018 · 2 comments

Comments

@tannerlinsley
Copy link

tannerlinsley commented Nov 5, 2018

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
When using Suspense, triggering several very-rapid non-cache hits locks up the nearest parent Suspense component until it is remounted.

If the current behavior is a bug, please provide the steps to reproduce

  • Visit https://codesandbox.io/s/00ml9vl9qv
  • Open Devtools to show the Network inspector
  • Click a post to view
  • Click the “Next” button (or focus it with your keyboard)
  • Press space bar multiple times very quickly (6 should do)
  • Inspect the network tab. You'll find that some of the later posts requests did not happen at all and that any further post requests made will also not be called.

What is the expected behavior?
All cache/resource requests should be called regardless of how quickly or how many pending requests are currently inflight.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React: 16.7.0-alpha.0
Browser: 70.0.3538.77 (Official Build) (64-bit)
OS: MacOS Mohave 10.14

@gaearon
Copy link
Collaborator

gaearon commented Nov 5, 2018

Likely same issue as #14013.
Can you try to see if fix in #14083 solves it?

@arianon
Copy link

arianon commented Nov 11, 2018

This looks like it indeed was fixed by #14083 (and therefore fixed in 16.6.1)

See: https://codesandbox.io/s/ko2xxq529r

@gaearon gaearon closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants