-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using reactjs.org instead of fb.me in react's error/warning messages #16109
Comments
We are considering this seriously. We are not sure when and how we'll do this, but it's on our minds. Thanks for the suggestion! |
One more reason is that current links require fb account! Please make this priority. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Not stale, I think we do want to do this sometime. |
@bencefr I don’t think you’re right? Definitely does not require an fb account |
@threepointone , it definitely does, since fb.me/... just redirects to facebook.com main page to sign up. |
@bencefr I just tested https://fb.me/react-invalid-hook-call and it redirects me to https://reactjs.org/warnings/invalid-hook-call-warning.html without forcing me to log in into my facebook account. |
My bad, the link I used had a typo and should have been a 404. The redirect works but I would be against using fb.me anyway. |
More data for this, fb.me is blocked inside lots of corporate environments as it's considered "social networking". While I'm working on getting it unblocked in my own firm, I don't expect that to actually happen soon. |
McAfee's TrustedSource categorizes |
I can't agree more with @val1984
@threepointone how did it go ? |
@threepointone @gaearon Redirect links might redirect to invalid links too, one of the example is fb.me/react-mock-scheduler I would suggest to create something like _redirects netlify, so that the public contributors can helps to update/monitoring the links whether needed. |
No worries. We appreciate the intent — it’s just unfortunate because that particular change isn’t something we can do. I think your proposal with _redirect makes sense. Is this something you would be interested in implementing? |
@gaearon Yes. I am happy to do it. I can see that reactjs.org is hosting on Netlify, and it is already _redirects using in reactjs.org website _redirects on reactjs.org. Any preferred path for the short link? I can start with |
Thanks to @cylim for taking this issue and spending the time to solve it. This will go out in 17. |
Thx a lot for this @cylim |
Hi,
Facebook is blocked in my country (and I think in some other countries) and links like
https://fb.me/react-invalid-hook-call
are blocked for me, in order to see the related documentation of the link I have to use VPN. so if is possible please use another link shortener service or point toreactjs.org
directly.Thanks.
The text was updated successfully, but these errors were encountered: