Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler should highlight host components (e.g. DOM elements) on mouseover #17928

Closed
bvaughn opened this issue Jan 29, 2020 · 8 comments · Fixed by #18745
Closed

Profiler should highlight host components (e.g. DOM elements) on mouseover #17928

bvaughn opened this issue Jan 29, 2020 · 8 comments · Fixed by #18745

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jan 29, 2020

Feature request from a DevTools user at Faceook:

If I mouse over a node in the flame graph if you can highlight it in the view like the inspector that would be really amazing!

@M-Izadmehr
Copy link
Contributor

Hi @bvaughn,
I really liked to check this issue, and I was able to create a PR to add highlighting for both FlameGraph and RankedList charts. (#17934 )

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 30, 2020

This issue is all yours! 😄

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@stale
Copy link

stale bot commented Apr 29, 2020

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Apr 29, 2020
@stale
Copy link

stale bot commented May 6, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed May 6, 2020
@bvaughn bvaughn reopened this May 6, 2020
@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label May 6, 2020
@steveadams
Copy link

Hi @bvaughn, I took a look at @M-Izadmehr 's work on this and thought I'd offer to get it over the finish line. They haven't been active on GitHub for a while, so if you'd like assistance I'd be happy to fork and resolve the remaining conflicts and get it delivered. Apologies if that's bad etiquette!

I'm looking for ways to get my feet wet and start contributing here 🙂

@bvaughn
Copy link
Contributor Author

bvaughn commented May 6, 2020

Feel free to create an updated PR if you'd like, @steveadams.

@steveadams
Copy link

Will do @bvaughn . Thanks for the speedy response!

@bl00mber
Copy link
Contributor

bl00mber commented May 7, 2020

@bvaughn I've sent an updated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants