Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Hovering "Rendered by" list should highlight elements #18472

Closed
gaearon opened this issue Apr 2, 2020 · 4 comments · Fixed by #18479
Closed

DevTools: Hovering "Rendered by" list should highlight elements #18472

gaearon opened this issue Apr 2, 2020 · 4 comments · Fixed by #18479

Comments

@gaearon
Copy link
Collaborator

gaearon commented Apr 2, 2020

This list is pretty awesome:

Screenshot 2020-04-03 at 00 12 08

But always struggle to guess which component in the owner list I need to jump to.

We should make hovering the owner list highlight components, just like the main tree view does.

@hristo-kanchev, interested?

@hristo-kanchev
Copy link
Contributor

Sure, @gaearon.

I'll try and have something in place by the end of the week.

I'll keep you updated :)

@hristo-kanchev
Copy link
Contributor

hristo-kanchev commented Apr 3, 2020

Something like this?

Light Theme:
OwnerButton-Hover

Dark Theme:
OwnerButton-Hover-Dark

@hristo-kanchev
Copy link
Contributor

I've updated the PR and added the highlight native element feature.

👇

HighlightRenderedBy

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 3, 2020

Amazing. This will help me a lot. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants