Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools Feature Request] Break on Warnings #19045

Closed
sebmarkbage opened this issue May 29, 2020 · 2 comments · Fixed by #19048
Closed

[DevTools Feature Request] Break on Warnings #19045

sebmarkbage opened this issue May 29, 2020 · 2 comments · Fixed by #19048
Assignees
@bvaughn
Labels
Component: Developer Tools Status: New Type: Feature Request

Comments

@sebmarkbage
Copy link
Collaborator

sebmarkbage commented May 29, 2020 •
edited
Loading

It'd be nice to have a toggle to pause the debugger when warnings fire so you can inspect the stack as it's happening.

console.error = function() {
  ...
  if (isBreakOn) {
    debugger;
  }
}

See #19044
@bvaughn
Copy link
Contributor

bvaughn commented May 29, 2020

What is "Status: New" haha

@bvaughn bvaughn self-assigned this May 29, 2020
@bvaughn
Copy link
Contributor

bvaughn commented May 29, 2020 •
edited
Loading

Looks like Webpack Terser is removing any debugger statements.

terser/terser#717

@bvaughn bvaughn mentioned this issue May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
Component: Developer Tools Status: New Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DevTools: Add break-on-warn feature bvaughn/react
2 participants
@bvaughn @sebmarkbage