-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: DevTools settings dialog no longer opens #21172
Comments
Changes to our sync scripts make bisecting slower. Have to build from source. 😁 This command is pretty fast way to build the minimum set of DevTools dependencies though: RELEASE_CHANNEL=experimental \
yarn build \
react/index,react-dom,react-is,react-debug-tools,scheduler,react-test-renderer,react-refresh \
--type=NODE_PROD I've confirmed that building the latest DevTools with an older version of React (09a2c36) fixes the regression. I'll bisect now. |
|
Isn't that basically working around #20074. Sounds like #20074 is now happening regardless of whether portals are rendered or not. So any solution you come up might be interesting to everybody. In Material-UI we just deferred "activation" with a crude We didn't use the |
I don't think I share Dan's concern about timestamp resolution in this case. See my comment here for rationale: #21173 (comment) |
Let's talk about it here (on the issue) or there (on the PR) but not both places 😁 |
Oh, I commented already. I thought I forgot to submit. |
Click the settings gear in either the inline or extension build and it does not open.
Edit: This was broken by a change to React via f8ef4ff / #21150
The text was updated successfully, but these errors were encountered: