Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-react-hooks CHANGELOG missing 4.4.0 release #24233

Closed
katerberg opened this issue Mar 31, 2022 · 2 comments · Fixed by #24234
Closed

eslint-plugin-react-hooks CHANGELOG missing 4.4.0 release #24233

katerberg opened this issue Mar 31, 2022 · 2 comments · Fixed by #24234
Assignees
Labels
Component: ESLint Rules Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@katerberg
Copy link

Currently the CHANGELOG shows 4.3.0 as the latest version of eslint-plugin-react-hooks, but at least on main, there is not a 4.4.0.

React version: n/a

Steps To Reproduce

  1. View Changelog
  2. Compare to version on https://www.npmjs.com/package/eslint-plugin-react-hooks

Link to code example: n/a

The current behavior

No 4.4.0 explanation in CHANGELOG.md

The expected behavior

4.4.0 explanation in CHANGELOG.md

@katerberg katerberg added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Mar 31, 2022
@bvaughn
Copy link
Contributor

bvaughn commented Mar 31, 2022

I think 4.4.0 was essentially a no-op release to correspond with React 18 release (though cc @acdlite to confirm). Looking at what's changed in the eslint-plugin-react-hooks package between the 4.3.0 release and Monday's 4.4.0 "release" I see:

git diff c3f34e4beb67a4ddd85a9456ebc9013d123aa6ee 34aa5cfe0d9b6ec4667e02bf46ab34d83dfb2d6d packages/eslint-plugin-react-hooks/
diff --git a/packages/eslint-plugin-react-hooks/package.json b/packages/eslint-plugin-react-hooks/package.json
index 6bf810a77..1c99c2ffd 100644
--- a/packages/eslint-plugin-react-hooks/package.json
+++ b/packages/eslint-plugin-react-hooks/package.json
@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-react-hooks",
   "description": "ESLint rules for React Hooks",
-  "version": "4.3.0",
+  "version": "4.4.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/facebook/react.git",
@@ -10,7 +10,6 @@
   "files": [
     "LICENSE",
     "README.md",
-    "build-info.json",
     "index.js",
     "cjs"
   ],

I believe this is the same thing as happened with the ESLint 4.2.0 release and React 17. I believe the "fix" here would be to just add a 4.4.0 release to the CHANGELOG that notes this.

@bvaughn bvaughn changed the title Bug: changelog is out of date eslint-plugin-react-hooks CHANGELOG missing 4.4.0 release Mar 31, 2022
@bvaughn bvaughn self-assigned this Mar 31, 2022
@katerberg
Copy link
Author

Thanks so much @bvaughn. That definitely seems like the right fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ESLint Rules Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants