Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic events proxy doesn't work for normal synthetic events #6187

Closed
zpao opened this issue Mar 4, 2016 · 3 comments
Closed

Synthetic events proxy doesn't work for normal synthetic events #6187

zpao opened this issue Mar 4, 2016 · 3 comments
Milestone

Comments

@zpao
Copy link
Member

zpao commented Mar 4, 2016

This blames to #5939, cc @kentcdodds

Not sure yet if this is affecting all load events or just ones that are attached directly to nodes (for eg image). But the problem is that when we intercept set operations for SyntheticEvents (but not "subclasses" like SyntheticMouseEvent), we don't have target.constructor @

!target.constructor.Interface.hasOwnProperty(prop) &&

Simplest repro: http://jsfiddle.net/ge8b0np9/ (will still fail w/o the load listener)

@zpao zpao added this to the 15.0 milestone Mar 4, 2016
@gaearon
Copy link
Collaborator

gaearon commented Mar 4, 2016

Isn’t this #5947 by @koba04?
@kentcdodds’s #5939 was similar but it didn’t use constructor or proxies.

@zpao
Copy link
Member Author

zpao commented Mar 4, 2016

oops, yea. Sorry for getting the blame wrong!

@kentcdodds
Copy link

Was just about to ask that :-)

👋 thanks for thinking of me! Let me know if I can help in any way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants