Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show component stack for invalid type warning during element creation #7856

Closed
sophiebits opened this issue Oct 3, 2016 · 2 comments · Fixed by #8495
Closed

Show component stack for invalid type warning during element creation #7856

sophiebits opened this issue Oct 3, 2016 · 2 comments · Fixed by #8495

Comments

@sophiebits
Copy link
Collaborator

When you do <Foo /> but Foo is not a valid string or function, we show an error message:

We include the owner name ("Please check the render method of Bar.") but not the full parent stack which we show for some of our other warnings like key warnings and prop types. We should call into ReactComponentTreeHook to get the full stack if possible.

@briandeheus
Copy link

Oh! I'm not sure if this the way to do it but I'm calling dibs on this one.

@briandeheus
Copy link

Alright, getting ready to send my PR! After lunch. 🍕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants