External packages not transforming process.env.NODE_ENV

[mridgway]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

process.env.NODE_ENV checks are being shipped to the browser.

What is the expected behavior?

In React, there is a browserify transform that converts process.env.NODE_ENV to the actual environment variable.

In package.json of React:

  "browserify": {
    "transform": [
      "loose-envify"
    ]
  }

Packages

• prop-types
• create-react-class
• react-addons-create-fragment
• react-transition-group

[mridgway]

@acdlite I can do a PR for create-react-class, but now I can't find the code for prop-types.

[gaearon]

It's in https://github.com/reactjs/prop-types.

[gaearon]

Does this mean we also need to do this for all addons? Or do they already have them?

[mridgway]

I'll look through the addons to see. Only the addons that use process.env.NODE_ENV will need to have it and I think most are already proxying to require('react/foo').

[gaearon]

I think most are already proxying to require('react/foo').

They shouldn't—the point of 15.5 release was to decouple (almost all) addons so they can keep existing when React 16 removes /lib/.

[mridgway]

I added a list to the description that shows which packages use process.env.NODE_ENV that don't include loose-envify. I can either add it to all of them or just the ones that use process.env.NODE_ENV. Up to you.

[gaearon]

Let's only add where necessary.

[gaearon]

create-react-class@15.5.3 and react-addons-create-fragment@15.5.4 should have the fixes.
Please let us know if this worked!

[mridgway]

Looks good. Thanks for the quick turnaround on these!