Code

RFC 6: Deprecate unsafe lifecycles#12028

Code

Merged

bvaughn merged 28 commits intofacebook:masterfacebook/react:masterfrom bvaughn:rfc-6bvaughn/react:rfc-6Copy head branch name to clipboardJan 19, 2018

+1,837-265

Commits

Commits on Jan 16, 2018

• Added unsafe_* lifecycles and deprecation warnings

  Show description for e709e30
  bvaughn

  committed
  e709e30

• Ran lifecycle hook codemod over project

  Show description for 404944e
  bvaughn

  committed
  404944e

• Manually migrated CoffeeScript and TypeScript tests

  bvaughn

  committed
  bd300b3

• Added inline note to createReactClassIntegration-test

  Show description for 2868176
  bvaughn

  committed
  2868176

• Udated NativeMethodsMixin with new lifecycle hooks

  bvaughn

  committed
  8679926

Commits on Jan 17, 2018

• Added static getDerivedStateFromProps to ReactPartialRenderer

  Show description for 64f27d7
  bvaughn

  committed
  64f27d7

• Added getDerivedStateFromProps to shallow renderer

  Show description for 1047182
  bvaughn

  committed
  1047182

• Dedupe and DEV-only deprecation warning in server renderer

  bvaughn

  committed
  035c220

• Renamed unsafe_* prefix to UNSAFE_* to be more noticeable

  bvaughn

  committed
  8d0e001

• Added getDerivedStateFromProps to ReactFiberClassComponent

  Show description for b71ca93
  bvaughn

  committed
  b71ca93

• Warn about UNSAFE_componentWillRecieveProps misspelling

  bvaughn

  committed
  09c39d0

• Added tests to createReactClassIntegration for new lifecycles

  bvaughn

  committed
  286df77

• Added warning for stateless functional components with gDSFP

  bvaughn

  committed
  b699543

Commits on Jan 18, 2018

• Added createReactClass test for static gDSFP

  bvaughn

  committed
  68f2fe7

• Moved lifecycle deprecation warnings behind (disabled) feature flag

  Show description for 2d9f75d
  bvaughn

  committed
  2d9f75d

• Tidying up

  bvaughn

  committed
  8f125b7

• Merge branch 'master' into rfc-6

  bvaughn

  committed
  1d3e3d5

• Tweaked warning message wording slightly

  Show description for d95ec49
  bvaughn

  committed
  d95ec49

• Replaced truthy partialState checks with != null

  bvaughn

  committed
  b940938

• Call getDerivedStateFromProps via .call(null) to prevent type access

  bvaughn

  committed
  6cd0a8e

• Move shallow-renderer didWarn* maps off the instance

  bvaughn

  committed
  7572667

• Only call getDerivedStateFromProps if props instance has changed

  bvaughn

  committed
  361a2cf

• Avoid creating new state object if not necessary

  bvaughn

  committed
  8178d52

• Inject state as a param to callGetDerivedStateFromProps

  Show description for 8d67e27
  bvaughn

  committed
  8d67e27

• Explicitly warn about uninitialized state before calling getDerivedStateFromProps.

  Show description for 53770c3
  bvaughn

  committed
  53770c3

• Improved wording for deprecation lifecycle warnings

  bvaughn

  committed
  3772ee2

• Merge branch 'master' into rfc-6

  bvaughn

  committed
  4dfa6e1

Commits on Jan 19, 2018

• Fix state-regression for module-pattern components

  Show description for 5609031
  bvaughn

  committed
  5609031