Dose rocksdb have the bug found in leveldb?

[strrchr]

Dose rocksdb have the bug found in leveldb?

Compaction causes data inconsistency when using snapshots
google/leveldb#320

[igorcanadi]

Thanks for the report. I ported the test from #339 PR and the tests pass (https://reviews.facebook.net/D54225). That doesn't mean we don't have a bug, though. I'll look a bit more into this.

[igorcanadi]

I just read the issue more throughly. RocksDB doesn't have the same bug. Looks like we actually found and fixed that bug years ago. I don't know why we didn't contribute back to LevelDB :(

The function that avoids the mistake in RocksDB code is ExpandWhileOverlapping:

rocksdb/db/compaction_picker.cc

Line 199 in 21e9581

bool CompactionPicker::ExpandWhileOverlapping(const std::string& cf_name,

[igorcanadi]

Thanks for the report, though! I will close this issue now.

[siying]

It does feel a valid bug in RocksDB. @igorcanadi if we always expand while overlapping, how come we had this bug? https://reviews.facebook.net/D51783

[igorcanadi]

So we fail to call ExpandWhileOverlapping()? If yes, then this is a valid bug.

[siying]

@igorcanadi you are right. I didn't find a place ExpandWhileOverlapping() fails to be called, and I'm not able to come up with a unit test that repros the issue.

[franksunjin]

I read ExpandWhileOverlapping, it is the same logic of the bugfix in google/leveldb#339

And the unit test pass, should able to resolve this issue