New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure block should be told the constraint size after clamping with min/max dimensions #201

Closed

molon opened this issue Jul 5, 2016 · 1 comment

molon commented Jul 5, 2016 •

edited

Loading

Thanks for the great library first.

css-layout call the measure block first https://github.com/facebook/css-layout/blob/6e05325f08207f624f5e2ef14c9301f6a6538bf8/src/Layout.c#L672-L709 and processing with boundAxis method second.

It lead us to have to clamp the constraint size with min/max dimensions ourself when we create a measure block.

Sorry, poor english lead to unclear expression.
Here is a demo below:
https://github.com/molon/MLLayout/tree/IssueOfCssLayout
The test located in SimpleViewController.m
https://github.com/molon/MLLayout/blob/IssueOfCssLayout/Example/MLLayoutDemo/SimpleViewController.m#L113-L133

The text was updated successfully, but these errors were encountered:

molon mentioned this issue

Use AT_MOST measurespec when onyl max dimension is defined #200

Merged

Contributor

emilsjolander commented Dec 25, 2016

We have fixed a lot of min/max issues since 6 months back. Closing this out now. If you still have issues please re-open.

emilsjolander closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment