Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Flow broken in master #1988

Closed
claudiopro opened this issue Feb 1, 2019 · 1 comment
Closed

Flow broken in master #1988

claudiopro opened this issue Feb 1, 2019 · 1 comment
Assignees
Labels
bug flow-types Issues related to Draft.js Flow types

Comments

@claudiopro
Copy link
Contributor

A recent commit broke the CI build: https://travis-ci.org/facebook/draft-js/jobs/487190873

@claudiopro claudiopro added bug flow-types Issues related to Draft.js Flow types labels Feb 1, 2019
@claudiopro claudiopro self-assigned this Feb 1, 2019
facebook-github-bot pushed a commit that referenced this issue Feb 1, 2019
Summary:
**Summary**

Fixes a CI build error (#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0

**Test Plan**

```
yarn run flow
flow src
```

```
→ flow src
The flow server's version didn't match the client's, so it exited.
Going to launch a new one.

Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src
Spawned flow server (pid=87525)
Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log
Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log
No errors!
```
Pull Request resolved: #1989

Reviewed By: pakoito

Differential Revision: D13917267

Pulled By: pakoito

fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
@claudiopro
Copy link
Contributor Author

Fixed by #1989

jdecked pushed a commit to twitter-forks/draft-js that referenced this issue Oct 9, 2019
…ookarchive#1989)

Summary:
**Summary**

Fixes a CI build error (facebookarchive#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0

**Test Plan**

```
yarn run flow
flow src
```

```
→ flow src
The flow server's version didn't match the client's, so it exited.
Going to launch a new one.

Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src
Spawned flow server (pid=87525)
Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log
Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log
No errors!
```
Pull Request resolved: facebookarchive#1989

Reviewed By: pakoito

Differential Revision: D13917267

Pulled By: pakoito

fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug flow-types Issues related to Draft.js Flow types
Projects
None yet
Development

No branches or pull requests

1 participant