We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function signature biasing jobs fail if types are similar but the textual representation is not. This is because the diffing logic here is simply text based and doesnt have a notion of a type. Eg: https://app.circleci.com/pipelines/github/facebookincubator/velox/46895/workflows/598bd983-d69a-49b5-8bd9-053372607bd3/jobs/322419
Incompatible changes in function signatures have been detected. 'in(T,T...) -> boolean' is changed to 'in(__user_T1,__user_T1...) -> boolean'.
We should extend the diffing logic to be cognizant of type and thus reduce these false positives.
N/A
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Problem description
Function signature biasing jobs fail if types are similar but the textual representation is not. This is because the diffing logic here is simply text based and doesnt have a notion of a type.
Eg:
https://app.circleci.com/pipelines/github/facebookincubator/velox/46895/workflows/598bd983-d69a-49b5-8bd9-053372607bd3/jobs/322419
We should extend the diffing logic to be cognizant of type and thus reduce these false positives.
System information
N/A
CMake log
The text was updated successfully, but these errors were encountered: