Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function signature biasing jobs are not cognizant of types #9240

Open
kgpai opened this issue Mar 25, 2024 · 0 comments
Open

Function signature biasing jobs are not cognizant of types #9240

kgpai opened this issue Mar 25, 2024 · 0 comments
Labels
build enhancement New feature or request

Comments

@kgpai
Copy link
Contributor

kgpai commented Mar 25, 2024

Problem description

Function signature biasing jobs fail if types are similar but the textual representation is not. This is because the diffing logic here is simply text based and doesnt have a notion of a type.
Eg:
https://app.circleci.com/pipelines/github/facebookincubator/velox/46895/workflows/598bd983-d69a-49b5-8bd9-053372607bd3/jobs/322419

Incompatible changes in function signatures have been detected.

'in(T,T...) -> boolean' is changed to 'in(__user_T1,__user_T1...) -> boolean'.

We should extend the diffing logic to be cognizant of type and thus reduce these false positives.

System information

N/A

CMake log

N/A
@kgpai kgpai added build triage Newly created issue that needs attention. enhancement New feature or request and removed triage Newly created issue that needs attention. labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant