Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Rename or nest the utils module in a detectron python module. #228

Closed
Erotemic opened this issue Mar 5, 2018 · 3 comments
Closed

Rename or nest the utils module in a detectron python module. #228

Erotemic opened this issue Mar 5, 2018 · 3 comments
Labels
bug enhancement

Comments

@Erotemic
Copy link

Erotemic commented Mar 5, 2018

In the current state of detectron the setup.py file installs a module called utils to site-packages. The name utils is uninformative and very likely to conflict with another module. Instead there should be a python package named detectron, which has a subpackage detectron.utils.
@rbgirshick
Copy link
Contributor

This was indeed a mistake. We plan to address it by putting non-tool scripts into a proper package.

@Erotemic
Copy link
Author

I've made a PR #265 that attempts to address this issue.

@rbgirshick rbgirshick mentioned this issue May 4, 2018
Open
@rbgirshick
Copy link
Contributor

Addressed by 261f7db.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbgirshick @Erotemic