Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce QuantizerTemplateScaling for SQ #3870

Closed
wants to merge 1 commit into from
Closed

Introduce QuantizerTemplateScaling for SQ #3870

wants to merge 1 commit into from

Conversation

alexanderguzhva
Copy link
Contributor

replace

template <class Codec, bool uniform, int SIMD>
struct QuantizerTemplate {};

with

enum class QuantizerTemplateScaling { UNIFORM = 0, NON_UNIFORM = 1 };

template <class Codec, QuantizerTemplateScaling SCALING, int SIMD>
struct QuantizerTemplate {};

This allows adding more Scalar Quantizer scaling types (such as rowwise or rowwise + non-uniform) in the future.

@alexanderguzhva
Introduce QuantizerTemplateScaling for SQ
7ff6068 
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
@facebook-github-bot
Copy link
Contributor

@mnorris11 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mnorris11 merged this pull request in 4e30901.

@mengdilin mengdilin mentioned this pull request Sep 20, 2024
Closed
facebook-github-bot pushed a commit that referenced this pull request Sep 21, 2024
@mengdilin @facebook-github-bot
Fix CI 2.0: Compile SQ for avx512 (#3880)
1f42e81 
Summary:
#3870 conflicted with changes in #3853 Rebasing D62989543 for PR 3853 internally did not catch the breakage since we don't have avx512 coverage internally unfortunately :(

=== Test Plan ===
Tested on a local machine and compilation and C++ tests worked
CI for AVX512 and conda build should succeed

Pull Request resolved: #3880

Reviewed By: junjieqi

Differential Revision: D63156374

Pulled By: mengdilin

fbshipit-source-id: 4bf51b2e7795bb55d388a31c79bded742f87d6e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Implementation Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderguzhva @facebook-github-bot @mnorris11