Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing dependency for bench_fw to *_cpu instead of *_gpu #3889

Closed
wants to merge 1 commit into from

Conversation

kuarora
Copy link
Contributor

@kuarora kuarora commented Sep 25, 2024

Summary:
1.Changing dependency for bench_fw to *_cpu instead of *_gpu

  • faiss_gpu and torch get incompatible. Once, that is fixed, I'll add gpu dependency back.
  • today, we are not using gpu in benchmarking yet.

2.Fixing some naming issue in kmeans which is used when using opaque as false in assemble.
3.codec_name when it is not assigned explicitly, it happens when using assembly

Differential Revision: D62671870

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62671870

…esearch#3889)

Summary:
Pull Request resolved: facebookresearch#3889

1.Changing dependency for bench_fw to *_cpu instead of *_gpu
 - faiss_gpu and torch get incompatible. Once, that is fixed, I'll add gpu dependency back.
- today, we are not using gpu in benchmarking yet.

2.Fixing some naming issue in kmeans which is used when using opaque as false in assemble.
3.codec_name when it is not assigned explicitly, it happens when using assembly

Reviewed By: satymish

Differential Revision: D62671870
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62671870

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d8aec60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants