Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the %Virta.Node module field a string? #1

Closed
Qqwy opened this issue Nov 3, 2018 · 1 comment
Closed

Why is the %Virta.Node module field a string? #1

Qqwy opened this issue Nov 3, 2018 · 1 comment

Comments

@Qqwy
Copy link

Qqwy commented Nov 3, 2018

Since you are directly referring to modules here, wouldn't it make sense to use the module name as atoms? Is there a deliberate choice to use strings instead? https://github.com/sarat1669/virta/blob/ac68e6d670a16784adbf7a91b5b935c2888e77ee/lib/instance.ex#L30 uses a roundabout way to get the module-atom from the string, which would not be necessary if the module name would just be used immediately.

@sarat1669
Copy link
Member

sarat1669 commented Nov 3, 2018

The end goal of this project is to have a UI to build the workflow. The graph will be represented in a JSON, so this was a choice I made. But as you mentioned, it should be an atom. The JSON transformer should ideally do the conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants