Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox cannot dial @fails-components/webtransport server #265

Closed
achingbrain opened this issue Mar 6, 2024 · 5 comments
Closed

Firefox cannot dial @fails-components/webtransport server #265

achingbrain opened this issue Mar 6, 2024 · 5 comments

Comments

@achingbrain
Copy link
Contributor

Here's a simple echo server

$ git clone https://github.com/achingbrain/webtransport-echo-server.git
$ cd webtransport-echo-server
$ npm i
$ npm run browser

> webtransport-echo-server@1.0.0 browser
> node browser.js

Paste the following code into https://codepen.io or similar:

(async function main ()  {
  console.info('CLIENT create session')
// ...more code here

Running the code in Chrome yields the expected* result:

"CLIENT create session"
"CLIENT wait for session"
"CLIENT session ready"
"CLIENT create bidi stream"
"CLIENT get writer"
"CLIENT wait for writer"
"CLIENT write"
"CLIENT close writer"
"CLIENT read from stream"
"CLIENT got from stream" // [object Object] 
{
  "done": false,
  "value": {
    "0": 0,
    "1": 1,
    "2": 2,
    "3": 3
  }
}
"CLIENT read from stream"

When running in Firefox Nightly (125.0a1 (2024-03-05) (64-bit)), the session never becomes ready:

"CLIENT create session"
"CLIENT wait for session"

* = the read stream doesn't end, but it won't until #256 ships

@martenrichter
Copy link
Member

But the firefox units worked so far. (But it is an older Firefox version).
Can you test it in the context of the Firefox unit test to figure out if it works there? (I made some analogue to your Chromium tests).
Is it the nightly including:
https://bugzilla.mozilla.org/show_bug.cgi?id=1873263
https://bugzilla.mozilla.org/show_bug.cgi?id=1872496
?

And then the question arises, if it is on my side or the browser side. (I learned that it is often not the fault of the package.)

@achingbrain
Copy link
Contributor Author

Ah, that first one was only merged about five hours ago, it's probably not in nightly yet - I'll check back at the end of the week.

@martenrichter
Copy link
Member

And I would be surprised if it did not work with the node.js server as I wrote the firefox patch testing against the unit test server of this package.

@achingbrain
Copy link
Contributor Author

Fingers crossed.

@achingbrain
Copy link
Contributor Author

Uncross your fingers, it all works with today's nightly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants