Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some credit card issuers are defunct #2344

Closed
matthewmayer opened this issue Aug 25, 2023 · 2 comments · Fixed by #2356
Closed

Some credit card issuers are defunct #2344

matthewmayer opened this issue Aug 25, 2023 · 2 comments · Fixed by #2356
Assignees
@matthewmayer
Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Milestone
v8.x

Comments

@matthewmayer
Copy link
Contributor

https://fakerjs.dev/api/finance.html#creditcardnumber

Various issuers found in the en locale are defunct:

https://en.wikipedia.org/wiki/Solo_(debit_card)
https://en.wikipedia.org/wiki/Switch_(debit_card)
https://en.wikipedia.org/wiki/Laser_(debit_card)
https://www.crunchbase.com/organization/instapayment-inc

https://github.com/faker-js/faker/blob/next/src/locales/en/finance/credit_card/index.ts

These should probably be removed, but this is a breaking change so defer to 9.0
@matthewmayer matthewmayer added breaking change Cannot be merged when next version is not a major release m: finance Something is referring to the finance module labels Aug 25, 2023
@matthewmayer matthewmayer added this to the v9 - Next major milestone Aug 25, 2023
@matthewmayer matthewmayer self-assigned this Aug 25, 2023
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Aug 26, 2023
@import-brain import-brain mentioned this issue Aug 27, 2023
Open
@xDivisionByZerox
Copy link
Member

Currently, we do not include locale data in semantic versioning. If we can change the structure of our lcoale definitions without having a breaking change we should not treat this change as breaking IMO.

@matthewmayer
Copy link
Contributor Author

faker.finance.creditCardNumber({issuer:"solo"})
'6767-4689-2489-3566-749'

If we just remove the definitions then creditCardNumber falls back to picking a random issuer instead. This is probably OK.

@matthewmayer matthewmayer removed the breaking change Cannot be merged when next version is not a major release label Aug 29, 2023
@matthewmayer matthewmayer mentioned this issue Aug 29, 2023
Merged
@ST-DDT ST-DDT added the c: locale Permutes locale definitions label Aug 30, 2023
@matthewmayer matthewmayer mentioned this issue Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

chore(finance): remove defunct credit card issuers matthewmayer/faker
3 participants
@matthewmayer @ST-DDT @xDivisionByZerox