Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default delay should be changed to 0 #37

Closed
YoavHortman opened this issue Dec 14, 2017 · 6 comments
Closed

Default delay should be changed to 0 #37

YoavHortman opened this issue Dec 14, 2017 · 6 comments

Comments

@YoavHortman
Copy link

I had a short load that I wanted to show to the client no matter how long it takes and the default delay was too long for it to show. I had to go back to the docs and try to understand why and after searching a bit I found the default delay is set to 1000ms.
Why isn't it set to 0 by default?

@Anandks1993
Copy link

Anandks1993 commented Dec 20, 2017

Anyhow we can change delay through props right ?

@fakiolinho
Copy link
Owner

Yes exactly @Anandks1993 😀

@YoavHortman
Copy link
Author

The point is this is not the expected behaviour and causes confusing outcomes in something that should be simple.

@Antman261
Copy link

Yes. This is very counterintuitive and easy to forget about. It has bitten us in the ass more than once. In fact right now I'm updating a dependency in a monorepo that uses react loading and will cause a cascade of updated packages with new dependencies.

Why? Because I have to set delay to 0.

@fakiolinho
Copy link
Owner

fakiolinho commented Feb 21, 2018

Hmm, sad to hear that the behaviour of delay causes all this frustration. I agree this is not that straightforward i mean it is not expected to function like that by default. The truth is that some guys asked this feature sometime ago. Anyways, I am thinking to update this in 2.0 version

@fakiolinho
Copy link
Owner

Default value is set to 0 in newly released version 2.0.0 so you don't have blocking conflicts with this 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants