Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source initialization requires (expensive) lookup for network interfaces #50

Closed
3 tasks done
fako1024 opened this issue Jun 25, 2023 · 0 comments · Fixed by #51
Closed
3 tasks done

Source initialization requires (expensive) lookup for network interfaces #50

fako1024 opened this issue Jun 25, 2023 · 0 comments · Fixed by #51
Assignees
Labels
enhancement New feature or request performance Performance / optimization related topics

Comments

@fako1024
Copy link
Owner

fako1024 commented Jun 25, 2023

Currently, setting up a new source triggers a call to net.InterfaceByName(<name>), which in turn calls a stack of methods to retrieve the current list of interfaces, leading to quite expensive syscall invocations. While being ok(ish) for single instances and / or few static interfaces, in situations where a lot of interfaces and / or a large number of instabilities (causing repeated up / down and hence re-initialization actions) this can cause significant overhead in total.

DoD

  • Assess options to minimize overhead (why is a deep call required to perform this lookup?)
  • Remove complex lookup call upon interface initialization
  • At least provide an option to provide a (reusable) net.Interfaces list upon initialization to reduce overhead when bulking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Performance / optimization related topics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant