Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asgi look examples to use aioredis 2 #1938

Closed
CaselIT opened this issue Aug 1, 2021 · 4 comments · Fixed by #1987
Closed

Update asgi look examples to use aioredis 2 #1938

CaselIT opened this issue Aug 1, 2021 · 4 comments · Fixed by #1987
Labels
documentation enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance
Milestone
Version 3.1

Comments

@CaselIT
Copy link
Member

CaselIT commented Aug 1, 2021

A new major vesion of aioredis was released, and it has some api changes.
This is the changelog https://github.com/aio-libs/aioredis-py/blob/master/CHANGELOG.md
@CaselIT CaselIT added this to the Version 3.1 milestone Aug 1, 2021
@CaselIT CaselIT mentioned this issue Aug 1, 2021
Merged
@vytas7 vytas7 added good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! Hacktoberfest needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! labels Oct 8, 2021
@the-bets
Copy link
Contributor

Myself and Mihai Todor can pick this up and work on it, if nobody else is!

@vytas7 vytas7 removed the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Oct 16, 2021
@vytas7
Copy link
Member

vytas7 commented Oct 16, 2021

Awesome @the-bets & @mihaitodor, go ahead!
(Bonus points if you find and fix any other funky things in that tutorial.)

@mihaitodor
Copy link
Contributor

Just FYI, I believe we figured out the required changes and we'll try to push a polished PR in the next few days.

@vytas7
Copy link
Member

vytas7 commented Oct 27, 2021

Good to hear @mihaitodor! Let us know if you run into any issues.

@the-bets the-bets mentioned this issue Nov 5, 2021
Merged
13 tasks
@vytas7 vytas7 mentioned this issue Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance
Projects
None yet
Milestone
Version 3.1
Development

Successfully merging a pull request may close this issue.

docs(examples/asgilook): update aioredis version to 2.0 the-bets/falcon
4 participants
@mihaitodor @vytas7 @CaselIT @the-bets