feat(testing): add raw_path to ASGI scope
#2331
Conversation
|
I have an issue with mypy, dunno if it's only me. It complains about line 680 in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2331 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7721 7722 +1
Branches 1269 1269
=========================================
+ Hits 7721 7722 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks for this initiative @aarcex3!
However, it seems there is a misunderstanding regarding the actual implementation.
In ASGI, raw path is presented as the raw_path key inside scope. The value is a bytestring path, excluding any query string.
Furthermore, I think this improvement warrants a newsfragment, let's add one.
vytas7
changed the title
raw_path to ASGI scope
There was a problem hiding this comment.
Thanks for this improvement, it seems to function as intended now!
I have a couple of nitpicks wrt testing (commented inline); and we also need a news fragment for this issue. The file should be named docs/_newsfragments/2262.newandimproved.rst.
Unfortunately, we have no bandwidth to help shaping up this PR for the impending beta release that we are trying to haste in order to catch up with CPython 3.13, so we'll have to postpone this PR to Falcon 4.1. No specific action is required from you wrt this point, this is just for reference, that we will not be able to merge this PR until 4.0.0 stable is out.
Summary of Changes
Added a 'raw_path' key to the asgi scope in
create_scopeto preserve the path and keep consistency as per #2159Related Issues
Closes #2262
Pull Request Checklist